| Message ID | 20211102101536.2958763-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clean-up for BPF_LOG_KERNEL log level | expand |
On Tue, Nov 02, 2021 at 06:15:34PM +0800, Hou Tao wrote: > There are just two clean-up patches for BPF_LOG_KERNEL log level: > patch #1 fixes the possible extra newline for bpf_log() and removes > the unnecessary calculation and truncation, and patch #2 disallows > BPF_LOG_KERNEL log level for bpf_btf_load(). Acked-by: Martin KaFai Lau <kafai@fb.com>
Hi Alexei, Could you please pick the patchset for v5.16 ? On 11/2/2021 6:15 PM, Hou Tao wrote: > Hi, > > There are just two clean-up patches for BPF_LOG_KERNEL log level: > patch #1 fixes the possible extra newline for bpf_log() and removes > the unnecessary calculation and truncation, and patch #2 disallows > BPF_LOG_KERNEL log level for bpf_btf_load(). > > Comments are welcome. > > Regards, > Tao > > Change Log: > v3: > * rebased on bpf-next > * address comments from Daniel Borkmann: > patch #1: add prefix "BPF: " instead of "BPF:" for error message > patch #2: remove uncessary parenthesis, keep the max buffer length > setting of btf verifier, and add Fixes tag. > > v2: https://www.spinics.net/lists/bpf/msg48809.html > * rebased on bpf-next > * patch #1: add a trailing newline if needed (suggested by Martin) > * add patch #2 > > v1: https://www.spinics.net/lists/bpf/msg48550.html > > Hou Tao (2): > bpf: clean-up bpf_verifier_vlog() for BPF_LOG_KERNEL log level > bpf: disallow BPF_LOG_KERNEL log level for bpf(BPF_BTF_LOAD) > > include/linux/bpf_verifier.h | 7 +++++++ > kernel/bpf/btf.c | 3 +-- > kernel/bpf/verifier.c | 16 +++++++++------- > 3 files changed, 17 insertions(+), 9 deletions(-) >
On Tue, Nov 30, 2021 at 3:48 AM Hou Tao <houtao1@huawei.com> wrote: > > Hi Alexei, > > Could you please pick the patchset for v5.16 ? Sorry it got lost in patchwork. Please resubmit. > On 11/2/2021 6:15 PM, Hou Tao wrote: > > Hi, > > > > There are just two clean-up patches for BPF_LOG_KERNEL log level: > > patch #1 fixes the possible extra newline for bpf_log() and removes > > the unnecessary calculation and truncation, and patch #2 disallows > > BPF_LOG_KERNEL log level for bpf_btf_load(). > > > > Comments are welcome. > > > > Regards, > > Tao > > > > Change Log: > > v3: > > * rebased on bpf-next > > * address comments from Daniel Borkmann: > > patch #1: add prefix "BPF: " instead of "BPF:" for error message > > patch #2: remove uncessary parenthesis, keep the max buffer length > > setting of btf verifier, and add Fixes tag. > > > > v2: https://www.spinics.net/lists/bpf/msg48809.html > > * rebased on bpf-next > > * patch #1: add a trailing newline if needed (suggested by Martin) > > * add patch #2 > > > > v1: https://www.spinics.net/lists/bpf/msg48550.html > > > > Hou Tao (2): > > bpf: clean-up bpf_verifier_vlog() for BPF_LOG_KERNEL log level > > bpf: disallow BPF_LOG_KERNEL log level for bpf(BPF_BTF_LOAD) > > > > include/linux/bpf_verifier.h | 7 +++++++ > > kernel/bpf/btf.c | 3 +-- > > kernel/bpf/verifier.c | 16 +++++++++------- > > 3 files changed, 17 insertions(+), 9 deletions(-) > > >
Hi, There are just two clean-up patches for BPF_LOG_KERNEL log level: patch #1 fixes the possible extra newline for bpf_log() and removes the unnecessary calculation and truncation, and patch #2 disallows BPF_LOG_KERNEL log level for bpf_btf_load(). Comments are welcome. Regards, Tao Change Log: v3: * rebased on bpf-next * address comments from Daniel Borkmann: patch #1: add prefix "BPF: " instead of "BPF:" for error message patch #2: remove uncessary parenthesis, keep the max buffer length setting of btf verifier, and add Fixes tag. v2: https://www.spinics.net/lists/bpf/msg48809.html * rebased on bpf-next * patch #1: add a trailing newline if needed (suggested by Martin) * add patch #2 v1: https://www.spinics.net/lists/bpf/msg48550.html Hou Tao (2): bpf: clean-up bpf_verifier_vlog() for BPF_LOG_KERNEL log level bpf: disallow BPF_LOG_KERNEL log level for bpf(BPF_BTF_LOAD) include/linux/bpf_verifier.h | 7 +++++++ kernel/bpf/btf.c | 3 +-- kernel/bpf/verifier.c | 16 +++++++++------- 3 files changed, 17 insertions(+), 9 deletions(-)