diff mbox series

[v6,10/10] ASoC: qcom: SC7280: Update config for building codec dma drivers

Message ID 1637928282-2819-11-git-send-email-srivasam@codeaurora.org (mailing list archive)
State Not Applicable
Headers show
Series Add support for audio on SC7280 based targets | expand

Commit Message

Srinivasa Rao Mandadapu Nov. 26, 2021, 12:04 p.m. UTC 
Add configuration for building SC7280 audio codec dma drivers.

Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org>
Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
---
This patch set depends on:
    -- https://patchwork.kernel.org/project/alsa-devel/list/?series=582321

 sound/soc/qcom/Kconfig  | 13 +++++++++++++
 sound/soc/qcom/Makefile |  4 ++++
 2 files changed, 17 insertions(+)

Comments

Mark Brown Nov. 26, 2021, 1:39 p.m. UTC | #1 
On Fri, Nov 26, 2021 at 05:34:42PM +0530, Srinivasa Rao Mandadapu wrote:

> This patch set depends on:
>     -- https://patchwork.kernel.org/project/alsa-devel/list/?series=582321

To repeat yet again:

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
Srinivas Kandagatla Dec. 1, 2021, 10:50 a.m. UTC | #2 
On 26/11/2021 12:04, Srinivasa Rao Mandadapu wrote:
> Add configuration for building SC7280 audio codec dma drivers.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org>
> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
> ---
> This patch set depends on:
>      -- https://patchwork.kernel.org/project/alsa-devel/list/?series=582321
> 
>   sound/soc/qcom/Kconfig  | 13 +++++++++++++
>   sound/soc/qcom/Makefile |  4 ++++
>   2 files changed, 17 insertions(+)
> 
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 530d01f..b46a2e7 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -20,6 +20,10 @@ config SND_SOC_LPASS_PLATFORM
>   	tristate
>   	select REGMAP_MMIO
>   
> +config SND_SOC_LPASS_CDC_DMA
> +	tristate
> +	select REGMAP_MMIO
> +
>   config SND_SOC_LPASS_IPQ806X
>   	tristate
>   	select SND_SOC_LPASS_CPU
> @@ -36,6 +40,13 @@ config SND_SOC_LPASS_SC7180
>   	select SND_SOC_LPASS_PLATFORM
>   	select SND_SOC_LPASS_HDMI
>   
> +config SND_SOC_LPASS_SC7280
> +	tristate
> +	select SND_SOC_LPASS_CPU
> +	select SND_SOC_LPASS_PLATFORM
> +	select SND_SOC_LPASS_HDMI
> +	select SND_SOC_LPASS_CDC_DMA
> +
>   config SND_SOC_STORM
>   	tristate "ASoC I2S support for Storm boards"
>   	select SND_SOC_LPASS_IPQ806X
> @@ -156,7 +167,9 @@ config SND_SOC_SC7280
>   	tristate "SoC Machine driver for SC7280 boards"
>   	depends on I2C && SOUNDWIRE || COMPILE_TEST
>   	select SND_SOC_QCOM_COMMON
> +	select SND_SOC_LPASS_SC7280
>   	select SND_SOC_MAX98357A
> +	select SND_SOC_WCD938X

Why are we updating machine Kconfigs in this patch, should that be not 
in your machine driver patch series?

I think I did point this out in previous versions too.


--srini


>   	select SND_SOC_LPASS_RX_MACRO
>   	select SND_SOC_LPASS_TX_MACRO
>   	help
> diff --git a/sound/soc/qcom/Makefile b/sound/soc/qcom/Makefile
> index 625aec6..8b7b876 100644
> --- a/sound/soc/qcom/Makefile
> +++ b/sound/soc/qcom/Makefile
> @@ -1,18 +1,22 @@
>   # SPDX-License-Identifier: GPL-2.0
>   # Platform
>   snd-soc-lpass-cpu-objs := lpass-cpu.o
> +snd-soc-lpass-cdc-dma-objs := lpass-cdc-dma.o
>   snd-soc-lpass-hdmi-objs := lpass-hdmi.o
>   snd-soc-lpass-platform-objs := lpass-platform.o
>   snd-soc-lpass-ipq806x-objs := lpass-ipq806x.o
>   snd-soc-lpass-apq8016-objs := lpass-apq8016.o
>   snd-soc-lpass-sc7180-objs := lpass-sc7180.o
> +snd-soc-lpass-sc7280-objs := lpass-sc7280.o
>   
>   obj-$(CONFIG_SND_SOC_LPASS_CPU) += snd-soc-lpass-cpu.o
> +obj-$(CONFIG_SND_SOC_LPASS_CDC_DMA) += snd-soc-lpass-cdc-dma.o
>   obj-$(CONFIG_SND_SOC_LPASS_HDMI) += snd-soc-lpass-hdmi.o
>   obj-$(CONFIG_SND_SOC_LPASS_PLATFORM) += snd-soc-lpass-platform.o
>   obj-$(CONFIG_SND_SOC_LPASS_IPQ806X) += snd-soc-lpass-ipq806x.o
>   obj-$(CONFIG_SND_SOC_LPASS_APQ8016) += snd-soc-lpass-apq8016.o
>   obj-$(CONFIG_SND_SOC_LPASS_SC7180) += snd-soc-lpass-sc7180.o
> +obj-$(CONFIG_SND_SOC_LPASS_SC7280) += snd-soc-lpass-sc7280.o
>   
>   # Machine
>   snd-soc-storm-objs := storm.o
>
Srinivasa Rao Mandadapu Dec. 1, 2021, 3:33 p.m. UTC | #3 
On 12/1/2021 4:20 PM, Srinivas Kandagatla wrote:
Thanks for Your time Srini!!!
>
> On 26/11/2021 12:04, Srinivasa Rao Mandadapu wrote:
>> Add configuration for building SC7280 audio codec dma drivers.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org>
>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
>> ---
>> This patch set depends on:
>>      -- 
>> https://patchwork.kernel.org/project/alsa-devel/list/?series=582321
>>
>>   sound/soc/qcom/Kconfig  | 13 +++++++++++++
>>   sound/soc/qcom/Makefile |  4 ++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
>> index 530d01f..b46a2e7 100644
>> --- a/sound/soc/qcom/Kconfig
>> +++ b/sound/soc/qcom/Kconfig
>> @@ -20,6 +20,10 @@ config SND_SOC_LPASS_PLATFORM
>>       tristate
>>       select REGMAP_MMIO
>>   +config SND_SOC_LPASS_CDC_DMA
>> +    tristate
>> +    select REGMAP_MMIO
>> +
>>   config SND_SOC_LPASS_IPQ806X
>>       tristate
>>       select SND_SOC_LPASS_CPU
>> @@ -36,6 +40,13 @@ config SND_SOC_LPASS_SC7180
>>       select SND_SOC_LPASS_PLATFORM
>>       select SND_SOC_LPASS_HDMI
>>   +config SND_SOC_LPASS_SC7280
>> +    tristate
>> +    select SND_SOC_LPASS_CPU
>> +    select SND_SOC_LPASS_PLATFORM
>> +    select SND_SOC_LPASS_HDMI
>> +    select SND_SOC_LPASS_CDC_DMA
>> +
>>   config SND_SOC_STORM
>>       tristate "ASoC I2S support for Storm boards"
>>       select SND_SOC_LPASS_IPQ806X
>> @@ -156,7 +167,9 @@ config SND_SOC_SC7280
>>       tristate "SoC Machine driver for SC7280 boards"
>>       depends on I2C && SOUNDWIRE || COMPILE_TEST
>>       select SND_SOC_QCOM_COMMON
>> +    select SND_SOC_LPASS_SC7280
>>       select SND_SOC_MAX98357A
>> +    select SND_SOC_WCD938X
>
> Why are we updating machine Kconfigs in this patch, should that be not 
> in your machine driver patch series?

Actually, SND_SOC_LPASS_SC7280 is of lpass-sc7280 platform driver.  
SND_SOC_WCD938X is for wcd codec driver.

Will add WCD Kconfig as separate patch.

>
> I think I did point this out in previous versions too.
>
>
> --srini
>
>
>>       select SND_SOC_LPASS_RX_MACRO
>>       select SND_SOC_LPASS_TX_MACRO
>>       help
>> diff --git a/sound/soc/qcom/Makefile b/sound/soc/qcom/Makefile
>> index 625aec6..8b7b876 100644
>> --- a/sound/soc/qcom/Makefile
>> +++ b/sound/soc/qcom/Makefile
>> @@ -1,18 +1,22 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   # Platform
>>   snd-soc-lpass-cpu-objs := lpass-cpu.o
>> +snd-soc-lpass-cdc-dma-objs := lpass-cdc-dma.o
>>   snd-soc-lpass-hdmi-objs := lpass-hdmi.o
>>   snd-soc-lpass-platform-objs := lpass-platform.o
>>   snd-soc-lpass-ipq806x-objs := lpass-ipq806x.o
>>   snd-soc-lpass-apq8016-objs := lpass-apq8016.o
>>   snd-soc-lpass-sc7180-objs := lpass-sc7180.o
>> +snd-soc-lpass-sc7280-objs := lpass-sc7280.o
>>     obj-$(CONFIG_SND_SOC_LPASS_CPU) += snd-soc-lpass-cpu.o
>> +obj-$(CONFIG_SND_SOC_LPASS_CDC_DMA) += snd-soc-lpass-cdc-dma.o
>>   obj-$(CONFIG_SND_SOC_LPASS_HDMI) += snd-soc-lpass-hdmi.o
>>   obj-$(CONFIG_SND_SOC_LPASS_PLATFORM) += snd-soc-lpass-platform.o
>>   obj-$(CONFIG_SND_SOC_LPASS_IPQ806X) += snd-soc-lpass-ipq806x.o
>>   obj-$(CONFIG_SND_SOC_LPASS_APQ8016) += snd-soc-lpass-apq8016.o
>>   obj-$(CONFIG_SND_SOC_LPASS_SC7180) += snd-soc-lpass-sc7180.o
>> +obj-$(CONFIG_SND_SOC_LPASS_SC7280) += snd-soc-lpass-sc7280.o
>>     # Machine
>>   snd-soc-storm-objs := storm.o
>>
diff mbox series

Patch

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 530d01f..b46a2e7 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -20,6 +20,10 @@  config SND_SOC_LPASS_PLATFORM
 	tristate
 	select REGMAP_MMIO
 
+config SND_SOC_LPASS_CDC_DMA
+	tristate
+	select REGMAP_MMIO
+
 config SND_SOC_LPASS_IPQ806X
 	tristate
 	select SND_SOC_LPASS_CPU
@@ -36,6 +40,13 @@  config SND_SOC_LPASS_SC7180
 	select SND_SOC_LPASS_PLATFORM
 	select SND_SOC_LPASS_HDMI
 
+config SND_SOC_LPASS_SC7280
+	tristate
+	select SND_SOC_LPASS_CPU
+	select SND_SOC_LPASS_PLATFORM
+	select SND_SOC_LPASS_HDMI
+	select SND_SOC_LPASS_CDC_DMA
+
 config SND_SOC_STORM
 	tristate "ASoC I2S support for Storm boards"
 	select SND_SOC_LPASS_IPQ806X
@@ -156,7 +167,9 @@  config SND_SOC_SC7280
 	tristate "SoC Machine driver for SC7280 boards"
 	depends on I2C && SOUNDWIRE || COMPILE_TEST
 	select SND_SOC_QCOM_COMMON
+	select SND_SOC_LPASS_SC7280
 	select SND_SOC_MAX98357A
+	select SND_SOC_WCD938X
 	select SND_SOC_LPASS_RX_MACRO
 	select SND_SOC_LPASS_TX_MACRO
 	help
diff --git a/sound/soc/qcom/Makefile b/sound/soc/qcom/Makefile
index 625aec6..8b7b876 100644
--- a/sound/soc/qcom/Makefile
+++ b/sound/soc/qcom/Makefile
@@ -1,18 +1,22 @@ 
 # SPDX-License-Identifier: GPL-2.0
 # Platform
 snd-soc-lpass-cpu-objs := lpass-cpu.o
+snd-soc-lpass-cdc-dma-objs := lpass-cdc-dma.o
 snd-soc-lpass-hdmi-objs := lpass-hdmi.o
 snd-soc-lpass-platform-objs := lpass-platform.o
 snd-soc-lpass-ipq806x-objs := lpass-ipq806x.o
 snd-soc-lpass-apq8016-objs := lpass-apq8016.o
 snd-soc-lpass-sc7180-objs := lpass-sc7180.o
+snd-soc-lpass-sc7280-objs := lpass-sc7280.o
 
 obj-$(CONFIG_SND_SOC_LPASS_CPU) += snd-soc-lpass-cpu.o
+obj-$(CONFIG_SND_SOC_LPASS_CDC_DMA) += snd-soc-lpass-cdc-dma.o
 obj-$(CONFIG_SND_SOC_LPASS_HDMI) += snd-soc-lpass-hdmi.o
 obj-$(CONFIG_SND_SOC_LPASS_PLATFORM) += snd-soc-lpass-platform.o
 obj-$(CONFIG_SND_SOC_LPASS_IPQ806X) += snd-soc-lpass-ipq806x.o
 obj-$(CONFIG_SND_SOC_LPASS_APQ8016) += snd-soc-lpass-apq8016.o
 obj-$(CONFIG_SND_SOC_LPASS_SC7180) += snd-soc-lpass-sc7180.o
+obj-$(CONFIG_SND_SOC_LPASS_SC7280) += snd-soc-lpass-sc7280.o
 
 # Machine
 snd-soc-storm-objs := storm.o