| Message ID | 20211201041228.32444-4-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Broadcom DT bindings conversion to YAML | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote: > MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores > and will be needed in order to convert GENET to YAML in subsequent > changes. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1561996 ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml ethernet@17020000: phy-handle: [[36], [37]] is too long arch/arm64/boot/dts/apm/apm-mustang.dt.yaml ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml
On 12/1/21 6:33 AM, Rob Herring wrote: > On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote: >> MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores >> and will be needed in order to convert GENET to YAML in subsequent >> changes. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1561996 > > > ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml > > ethernet@17020000: phy-handle: [[36], [37]] is too long > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml > > ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] > arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml > arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml These are all pre-existing warnings, but we should be documenting speed 2500 in ethernet-controller.yaml, so I will add a patch towards that end. The one for apm-mustand.dts however I am not sure how to best resolve since it looks like there was an intention to provide two Ethernet PHYs and presumably have the firmware prune the one that is not in use. I don't even know if that platform is supported mainline anymore.
On Wed, Dec 1, 2021 at 11:15 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > On 12/1/21 6:33 AM, Rob Herring wrote: > > On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote: > >> MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores > >> and will be needed in order to convert GENET to YAML in subsequent > >> changes. > >> > >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > >> --- > >> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1561996 > > > > > > ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml > > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml > > > > ethernet@17020000: phy-handle: [[36], [37]] is too long > > arch/arm64/boot/dts/apm/apm-mustang.dt.yaml > > > > ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000] > > arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml > > arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml > > These are all pre-existing warnings, but we should be documenting speed > 2500 in ethernet-controller.yaml, so I will add a patch towards that end. Thanks. > The one for apm-mustand.dts however I am not sure how to best resolve > since it looks like there was an intention to provide two Ethernet PHYs > and presumably have the firmware prune the one that is not in use. I > don't even know if that platform is supported mainline anymore. Unfortunately it is, barely. I just fixed a breakage I caused 2 years ago and just now noticed. I would not worry about it for now. Rob
diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml index b0933a8c295a..31bfec8bb674 100644 --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml @@ -69,6 +69,7 @@ properties: - rev-mii - rmii - rev-rmii + - moca # RX and TX delays are added by the MAC when required - rgmii
MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores and will be needed in order to convert GENET to YAML in subsequent changes. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + 1 file changed, 1 insertion(+)