| Message ID | d0dcd227-0753-5e9d-f757-4819cc271d4f@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Kernel oops bisected to media: videobuf2: move cache_hints handling to allocators | expand |
Hello, On (21/11/19 22:41), Daniel Scally wrote: > Hi all > > I've been experiencing an oops trying to run libcamera's qcam util > (which starts streaming on a camera sensor - the ov8865), which I > bisected down to the patch cde513fd9b35: "media: videobuf2: move > cache_hints handling to allocators" Can you please check if you have these two patches in your tree: https://lore.kernel.org/lkml/20210928034634.333785-1-senozhatsky@chromium.org/raw https://lore.kernel.org/all/20211101145355.533704-1-hdegoede@redhat.com/raw If not then please apply, this should fix the problems you're seeing.
Daniel: ping! On 20/11/2021 04:26, Sergey Senozhatsky wrote: > Hello, > > On (21/11/19 22:41), Daniel Scally wrote: >> Hi all >> >> I've been experiencing an oops trying to run libcamera's qcam util >> (which starts streaming on a camera sensor - the ov8865), which I >> bisected down to the patch cde513fd9b35: "media: videobuf2: move >> cache_hints handling to allocators" > > Can you please check if you have these two patches in your tree: > > https://lore.kernel.org/lkml/20210928034634.333785-1-senozhatsky@chromium.org/raw > https://lore.kernel.org/all/20211101145355.533704-1-hdegoede@redhat.com/raw > > If not then please apply, this should fix the problems you're seeing. > I really like to know if the cause is indeed that you are missing two patches. Regards, Hans
Hello On 02/12/2021 11:15, Hans Verkuil wrote: > Daniel: ping! > > On 20/11/2021 04:26, Sergey Senozhatsky wrote: >> Hello, >> >> On (21/11/19 22:41), Daniel Scally wrote: >>> Hi all >>> >>> I've been experiencing an oops trying to run libcamera's qcam util >>> (which starts streaming on a camera sensor - the ov8865), which I >>> bisected down to the patch cde513fd9b35: "media: videobuf2: move >>> cache_hints handling to allocators" >> Can you please check if you have these two patches in your tree: >> >> https://lore.kernel.org/lkml/20210928034634.333785-1-senozhatsky@chromium.org/raw >> https://lore.kernel.org/all/20211101145355.533704-1-hdegoede@redhat.com/raw >> >> If not then please apply, this should fix the problems you're seeing. >> > I really like to know if the cause is indeed that you are missing two patches. I'm sorry, I missed this. I'll check it asap and let you know. > > Regards, > > Hans
Hi Hans On 02/12/2021 11:15, Hans Verkuil wrote: > Daniel: ping! > > On 20/11/2021 04:26, Sergey Senozhatsky wrote: >> Hello, >> >> On (21/11/19 22:41), Daniel Scally wrote: >>> Hi all >>> >>> I've been experiencing an oops trying to run libcamera's qcam util >>> (which starts streaming on a camera sensor - the ov8865), which I >>> bisected down to the patch cde513fd9b35: "media: videobuf2: move >>> cache_hints handling to allocators" >> Can you please check if you have these two patches in your tree: >> >> https://lore.kernel.org/lkml/20210928034634.333785-1-senozhatsky@chromium.org/raw >> https://lore.kernel.org/all/20211101145355.533704-1-hdegoede@redhat.com/raw >> >> If not then please apply, this should fix the problems you're seeing. >> > I really like to know if the cause is indeed that you are missing two patches. Apologies for the delayed response - I was indeed missing those patches and, having added them, everything's working fine. > > Regards, > > Hans
On 07/12/2021 22:41, Daniel Scally wrote: > Hi Hans > > On 02/12/2021 11:15, Hans Verkuil wrote: >> Daniel: ping! >> >> On 20/11/2021 04:26, Sergey Senozhatsky wrote: >>> Hello, >>> >>> On (21/11/19 22:41), Daniel Scally wrote: >>>> Hi all >>>> >>>> I've been experiencing an oops trying to run libcamera's qcam util >>>> (which starts streaming on a camera sensor - the ov8865), which I >>>> bisected down to the patch cde513fd9b35: "media: videobuf2: move >>>> cache_hints handling to allocators" >>> Can you please check if you have these two patches in your tree: >>> >>> https://lore.kernel.org/lkml/20210928034634.333785-1-senozhatsky@chromium.org/raw >>> https://lore.kernel.org/all/20211101145355.533704-1-hdegoede@redhat.com/raw >>> >>> If not then please apply, this should fix the problems you're seeing. >>> >> I really like to know if the cause is indeed that you are missing two patches. > > > Apologies for the delayed response - I was indeed missing those patches > and, having added them, everything's working fine. Great! Thank you for taking the time to confirm this. Regards, Hans
diff --git a/drivers/media/common/videobuf2/videobuf2-dma-sg.c b/drivers/media/common/videobuf2/videobuf2-dma-sg.c index 1094575abf95..937f86b93013 100644 --- a/drivers/media/common/videobuf2/videobuf2-dma-sg.c +++ b/drivers/media/common/videobuf2/videobuf2-dma-sg.c @@ -204,7 +204,7 @@ static void vb2_dma_sg_prepare(void *buf_priv) struct vb2_dma_sg_buf *buf = buf_priv; struct sg_table *sgt = buf->dma_sgt; - if (buf->vb->skip_cache_sync_on_prepare) + if (buf->vb && buf->vb->skip_cache_sync_on_prepare) return; dma_sync_sgtable_for_device(buf->dev, sgt, buf->dma_dir);