mbox series

[0/4] HID: followup of uhid crashes, and couple of core

Message ID 20211202095334.14399-1-benjamin.tissoires@redhat.com (mailing list archive)
Headers show
Series HID: followup of uhid crashes, and couple of core | expand

Message

Benjamin Tissoires Dec. 2, 2021, 9:53 a.m. UTC 
Hi,

this is a followup of Greg's series[0].
hid-sony is having a wrong error path leading to unreleased
hidraw nodes, and bigbenff is having a crash when used with
a wrong report descriptor in uhid.

Those 2 first patches should IMO go into 5.16.

The 2 others are some core changes I had locally stacked and
which should be ready to go now. They can be scheduled for 5.16
or 5.17, there is no rush for them.

Cheers,
Benjamin


[0] https://lore.kernel.org/linux-input/20211201183503.2373082-1-gregkh@linuxfoundation.org/


Benjamin Tissoires (4):
  HID: sony: fix error path in probe
  HID: bigbenff: prevent null pointer dereference
  HID: add suspend/resume helpers
  HID: do not inline some hid_hw_ functions

 drivers/hid/hid-bigbenff.c                 |  2 +-
 drivers/hid/hid-core.c                     | 93 ++++++++++++++++++++++
 drivers/hid/hid-sony.c                     | 22 +++--
 drivers/hid/i2c-hid/i2c-hid-core.c         | 15 +---
 drivers/hid/surface-hid/surface_hid_core.c | 25 ++----
 drivers/hid/usbhid/hid-core.c              | 19 ++---
 include/linux/hid.h                        | 78 ++++--------------
 7 files changed, 142 insertions(+), 112 deletions(-)

Comments

Greg KH Dec. 2, 2021, 11:48 a.m. UTC | #1 
On Thu, Dec 02, 2021 at 10:53:30AM +0100, Benjamin Tissoires wrote:
> Hi,
> 
> this is a followup of Greg's series[0].
> hid-sony is having a wrong error path leading to unreleased
> hidraw nodes, and bigbenff is having a crash when used with
> a wrong report descriptor in uhid.
> 
> Those 2 first patches should IMO go into 5.16.
> 
> The 2 others are some core changes I had locally stacked and
> which should be ready to go now. They can be scheduled for 5.16
> or 5.17, there is no rush for them.
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Tissoires Dec. 2, 2021, 4:48 p.m. UTC | #2 
On Thu, Dec 2, 2021 at 12:49 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Dec 02, 2021 at 10:53:30AM +0100, Benjamin Tissoires wrote:
> > Hi,
> >
> > this is a followup of Greg's series[0].
> > hid-sony is having a wrong error path leading to unreleased
> > hidraw nodes, and bigbenff is having a crash when used with
> > a wrong report descriptor in uhid.
> >
> > Those 2 first patches should IMO go into 5.16.
> >
> > The 2 others are some core changes I had locally stacked and
> > which should be ready to go now. They can be scheduled for 5.16
> > or 5.17, there is no rush for them.
> >
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>

Patches 1 and 2 are applied to hid.git branch for-5.16/upstream-fixes
Patches 3 and 4 are applied to hid.git branch for-5.17/core

Cheers,
Benjamin