diff mbox series

[2/2] fs/dcache: avoid unused-function warning

Message ID 20211203190123.874239-2-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] fs/inode: avoid unused-variable warning | expand

Commit Message

Arnd Bergmann Dec. 3, 2021, 7:01 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Now that 'dentry_stat' is marked 'static', we can run into this warning:

fs/dcache.c:128:29: error: 'dentry_stat' defined but not used [-Werror=unused-variable]
  128 | static struct dentry_stat_t dentry_stat = {

Hide it in the same #ifdef as its only references.

Fixes: f0eea17ca8da ("fs: move dcache sysctls to its own file")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/dcache.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Christian Brauner Dec. 4, 2021, 11:57 a.m. UTC | #1 
On Fri, Dec 03, 2021 at 08:01:02PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Now that 'dentry_stat' is marked 'static', we can run into this warning:
> 
> fs/dcache.c:128:29: error: 'dentry_stat' defined but not used [-Werror=unused-variable]
>   128 | static struct dentry_stat_t dentry_stat = {
> 
> Hide it in the same #ifdef as its only references.
> 
> Fixes: f0eea17ca8da ("fs: move dcache sysctls to its own file")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
diff mbox series

Patch

diff --git a/fs/dcache.c b/fs/dcache.c
index 0eef1102f460..c84269c6e8bf 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -124,16 +124,15 @@  struct dentry_stat_t {
 	long dummy;		/* Reserved for future use */
 };
 
-/* Statistics gathering. */
-static struct dentry_stat_t dentry_stat = {
-	.age_limit = 45,
-};
-
 static DEFINE_PER_CPU(long, nr_dentry);
 static DEFINE_PER_CPU(long, nr_dentry_unused);
 static DEFINE_PER_CPU(long, nr_dentry_negative);
 
 #if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
+/* Statistics gathering. */
+static struct dentry_stat_t dentry_stat = {
+	.age_limit = 45,
+};
 
 /*
  * Here we resort to our own counters instead of using generic per-cpu counters