[v4,0/2] Add Qualcomm MPM irqchip driver support

Message

Shawn Guo Dec. 6, 2021, 9:25 a.m. UTC

It adds DT binding and driver support for Qualcomm MPM (MSM Power Manager)
interrupt controller.

Changes for v4:
- Add the missing include of <linux/interrupt.h> to fix build errors
  on arm architecture.
- Leave IRQCHIP_PLATFORM_DRIVER infrastructural unchanged, and use
  of_find_device_by_node() to get platform_device pointer.

Changes for v3:
- Support module build
- Use relaxed accessors
- Add barrier call to ensure MMIO write completes
- Use d->chip_data to pass driver private data
- Use raw spinlock
- USe BIT() for bit shift
- Create a single irq domain to cover both types of MPM pins
- Call irq_resolve_mapping() to find out Linux irq number
- Save the use of ternary conditional operator and use switch/case for
  .irq_set_type call
- Drop unnecessary .irq_disable hook
- Align qcom_mpm_chip and qcom_mpm_ops members vertically
- Use helper irq_domain_translate_twocell()
- Move mailbox requesting forward in probe function
- Improve the documentation on qcm2290_gic_pins[]
- Use IRQCHIP_PLATFORM_DRIVER infrastructural
- Use cpu_pm notifier instead of .suspend_late hook to write MPM for
  sleep, so that MPM can be set up for both suspend and idle context.
  The TIMER0/1 setup is currently omitted for idle use case though,
  as I haven't been able to successfully test the idle context.

Shawn Guo (2):
  dt-bindings: interrupt-controller: Add Qualcomm MPM support
  irqchip: Add Qualcomm MPM controller driver

 .../interrupt-controller/qcom,mpm.yaml        |  72 +++
 drivers/irqchip/Kconfig                       |   8 +
 drivers/irqchip/Makefile                      |   1 +
 drivers/irqchip/qcom-mpm.c                    | 480 ++++++++++++++++++
 4 files changed, 561 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
 create mode 100644 drivers/irqchip/qcom-mpm.c

Comments

Marc Zyngier Dec. 6, 2021, 9:59 a.m. UTC | #1

On Mon, 06 Dec 2021 09:25:33 +0000,
Shawn Guo <[e-mail]> wrote:
> 
> It adds DT binding and driver support for Qualcomm MPM (MSM Power Manager)
> interrupt controller.

That's the 4th version in exactly two weeks, and that still has all
the problems I commented on in v3.

I won't review a new version this week.

	M.

Shawn Guo Dec. 6, 2021, 11:47 a.m. UTC | #2

On Mon, Dec 06, 2021 at 09:59:05AM +0000, Marc Zyngier wrote:
> On Mon, 06 Dec 2021 09:25:33 +0000,
> Shawn Guo <[e-mail]> wrote:
> > 
> > It adds DT binding and driver support for Qualcomm MPM (MSM Power Manager)
> > interrupt controller.
> 
> That's the 4th version in exactly two weeks, and that still has all
> the problems I commented on in v3.

I mistakenly thought you had looked at v3, and v4 was sent out before I
receive your reviewing on v3.  I will slow down the posting.

> 
> I won't review a new version this week.

Sure.  This is not anything urgent.

Shawn