| Message ID | 20211206210224.157070464@linutronix.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | genirq/msi, PCI/MSI: Spring cleaning - Part 1 | expand |
On Mon, Dec 06, 2021 at 11:27:33PM +0100, Thomas Gleixner wrote: > There is no point to have this function public as it is set by the PCI core > anyway when a PCI/MSI irqdomain is created. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Tested-by: Juergen Gross <jgross@suse.com> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI > --- > drivers/irqchip/irq-gic-v2m.c | 1 - > drivers/irqchip/irq-gic-v3-its-pci-msi.c | 1 - > drivers/irqchip/irq-gic-v3-mbi.c | 1 - > drivers/pci/msi.c | 2 +- > include/linux/msi.h | 1 - > 5 files changed, 1 insertion(+), 5 deletions(-) > > --- a/drivers/irqchip/irq-gic-v2m.c > +++ b/drivers/irqchip/irq-gic-v2m.c > @@ -88,7 +88,6 @@ static struct irq_chip gicv2m_msi_irq_ch > .irq_mask = gicv2m_mask_msi_irq, > .irq_unmask = gicv2m_unmask_msi_irq, > .irq_eoi = irq_chip_eoi_parent, > - .irq_write_msi_msg = pci_msi_domain_write_msg, > }; > > static struct msi_domain_info gicv2m_msi_domain_info = { > --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c > +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c > @@ -28,7 +28,6 @@ static struct irq_chip its_msi_irq_chip > .irq_unmask = its_unmask_msi_irq, > .irq_mask = its_mask_msi_irq, > .irq_eoi = irq_chip_eoi_parent, > - .irq_write_msi_msg = pci_msi_domain_write_msg, > }; > > static int its_pci_msi_vec_count(struct pci_dev *pdev, void *data) > --- a/drivers/irqchip/irq-gic-v3-mbi.c > +++ b/drivers/irqchip/irq-gic-v3-mbi.c > @@ -171,7 +171,6 @@ static struct irq_chip mbi_msi_irq_chip > .irq_unmask = mbi_unmask_msi_irq, > .irq_eoi = irq_chip_eoi_parent, > .irq_compose_msi_msg = mbi_compose_msi_msg, > - .irq_write_msi_msg = pci_msi_domain_write_msg, > }; > > static struct msi_domain_info mbi_msi_domain_info = { > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -1281,7 +1281,7 @@ EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdat > * @irq_data: Pointer to interrupt data of the MSI interrupt > * @msg: Pointer to the message > */ > -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) > +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) > { > struct msi_desc *desc = irq_data_get_msi_desc(irq_data); > > --- a/include/linux/msi.h > +++ b/include/linux/msi.h > @@ -455,7 +455,6 @@ void *platform_msi_get_host_data(struct > #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */ > > #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN > -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg); > struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode, > struct msi_domain_info *info, > struct irq_domain *parent); >
--- a/drivers/irqchip/irq-gic-v2m.c +++ b/drivers/irqchip/irq-gic-v2m.c @@ -88,7 +88,6 @@ static struct irq_chip gicv2m_msi_irq_ch .irq_mask = gicv2m_mask_msi_irq, .irq_unmask = gicv2m_unmask_msi_irq, .irq_eoi = irq_chip_eoi_parent, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static struct msi_domain_info gicv2m_msi_domain_info = { --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c @@ -28,7 +28,6 @@ static struct irq_chip its_msi_irq_chip .irq_unmask = its_unmask_msi_irq, .irq_mask = its_mask_msi_irq, .irq_eoi = irq_chip_eoi_parent, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static int its_pci_msi_vec_count(struct pci_dev *pdev, void *data) --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -171,7 +171,6 @@ static struct irq_chip mbi_msi_irq_chip .irq_unmask = mbi_unmask_msi_irq, .irq_eoi = irq_chip_eoi_parent, .irq_compose_msi_msg = mbi_compose_msi_msg, - .irq_write_msi_msg = pci_msi_domain_write_msg, }; static struct msi_domain_info mbi_msi_domain_info = { --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -1281,7 +1281,7 @@ EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdat * @irq_data: Pointer to interrupt data of the MSI interrupt * @msg: Pointer to the message */ -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg) { struct msi_desc *desc = irq_data_get_msi_desc(irq_data); --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -455,7 +455,6 @@ void *platform_msi_get_host_data(struct #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */ #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg); struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode, struct msi_domain_info *info, struct irq_domain *parent);