mbox series

[00/17] PCI: aardvark controller fixes BATCH 4

Message ID 20211208061851.31867-1-kabel@kernel.org (mailing list archive)
Headers show
Series PCI: aardvark controller fixes BATCH 4 | expand

Message

Marek Behún Dec. 8, 2021, 6:18 a.m. UTC
Hello Lorenzo, Marc,

this is batch 4 of patches for Aardvark PCIe controller driver.

This series mainly fixes and adds support for stuff around interrupts.
(All but the first one.)

I have rebased it sot that first come patches that change the API to the
new one, as Marc requested. Marc, could you find time to review these?

Marek

Marek Behún (1):
  PCI: aardvark: Drop __maybe_unused from advk_pcie_disable_phy()

Pali Rohár (16):
  PCI: aardvark: Rewrite IRQ code to chained IRQ handler
  PCI: aardvark: Fix support for MSI interrupts
  PCI: aardvark: Fix reading MSI interrupt number
  PCI: aardvark: Refactor unmasking summary MSI interrupt
  PCI: aardvark: Add support for masking MSI interrupts
  PCI: aardvark: Fix setting MSI address
  PCI: aardvark: Enable MSI-X support
  PCI: aardvark: Add support for ERR interrupt on emulated bridge
  PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge
  PCI: aardvark: Optimize writing PCI_EXP_RTCTL_PMEIE and
    PCI_EXP_RTSTA_PME on emulated bridge
  PCI: aardvark: Add support for PME interrupts
  PCI: aardvark: Fix support for PME requester on emulated bridge
  PCI: aardvark: Use separate INTA interrupt for emulated root bridge
  PCI: aardvark: Check return value of generic_handle_domain_irq() when
    processing INTx IRQ
  PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts
  PCI: aardvark: Don't mask irq when mapping

 drivers/pci/controller/pci-aardvark.c | 332 +++++++++++++++++++-------
 1 file changed, 245 insertions(+), 87 deletions(-)

Comments

Marek Behún Dec. 8, 2021, 6:22 a.m. UTC | #1
Hello Marc,

sorry about this, I wanted to send this series also to you, but
I accidentally sent it to your @arm.com e-mail address.
Does that address still work? Should I resend to your @kernel.org
address?

Marek

On Wed,  8 Dec 2021 07:18:34 +0100
Marek Behún <kabel@kernel.org> wrote:

> Hello Lorenzo, Marc,
> 
> this is batch 4 of patches for Aardvark PCIe controller driver.
> 
> This series mainly fixes and adds support for stuff around interrupts.
> (All but the first one.)
> 
> I have rebased it sot that first come patches that change the API to the
> new one, as Marc requested. Marc, could you find time to review these?
> 
> Marek
> 
> Marek Behún (1):
>   PCI: aardvark: Drop __maybe_unused from advk_pcie_disable_phy()
> 
> Pali Rohár (16):
>   PCI: aardvark: Rewrite IRQ code to chained IRQ handler
>   PCI: aardvark: Fix support for MSI interrupts
>   PCI: aardvark: Fix reading MSI interrupt number
>   PCI: aardvark: Refactor unmasking summary MSI interrupt
>   PCI: aardvark: Add support for masking MSI interrupts
>   PCI: aardvark: Fix setting MSI address
>   PCI: aardvark: Enable MSI-X support
>   PCI: aardvark: Add support for ERR interrupt on emulated bridge
>   PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge
>   PCI: aardvark: Optimize writing PCI_EXP_RTCTL_PMEIE and
>     PCI_EXP_RTSTA_PME on emulated bridge
>   PCI: aardvark: Add support for PME interrupts
>   PCI: aardvark: Fix support for PME requester on emulated bridge
>   PCI: aardvark: Use separate INTA interrupt for emulated root bridge
>   PCI: aardvark: Check return value of generic_handle_domain_irq() when
>     processing INTx IRQ
>   PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts
>   PCI: aardvark: Don't mask irq when mapping
> 
>  drivers/pci/controller/pci-aardvark.c | 332 +++++++++++++++++++-------
>  1 file changed, 245 insertions(+), 87 deletions(-)
>
Marc Zyngier Dec. 8, 2021, 7:55 a.m. UTC | #2
On 2021-12-08 06:22, Marek Behún wrote:
> Hello Marc,
> 
> sorry about this, I wanted to send this series also to you, but
> I accidentally sent it to your @arm.com e-mail address.
> Does that address still work? Should I resend to your @kernel.org
> address?

My @arm.com address stopped working over two years ago. I guess
my ex-manager is busy reviewing your patches!

No need to resend, I'll fetch the series from lore.

Thanks,

         M.
Marek Behún Jan. 4, 2022, 6:41 p.m. UTC | #3
On Wed, 08 Dec 2021 07:55:48 +0000
Marc Zyngier <maz@kernel.org> wrote:

> On 2021-12-08 06:22, Marek Behún wrote:
> > Hello Marc,
> > 
> > sorry about this, I wanted to send this series also to you, but
> > I accidentally sent it to your @arm.com e-mail address.
> > Does that address still work? Should I resend to your @kernel.org
> > address?  
> 
> My @arm.com address stopped working over two years ago. I guess
> my ex-manager is busy reviewing your patches!
> 
> No need to resend, I'll fetch the series from lore.
> 
> Thanks,
> 
>          M.

Hello Marc,

did you manage to find some time to look at this series?

Thanks.

Marek