| Message ID | 20211208192118.7483-10-s.shtylyov@omp.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Wed, Dec 08, 2021 at 10:21:17PM +0300, Sergey Shtylyov wrote: > The driver overrides the error codes returned by platform_get_irq() to > -ENXIO for some strange reason, so if it returns -EPROBE_DEFER, the driver > will fail the probe permanently instead of the deferred probing. Switch to > propagating the error codes upstream. > > Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008") I don't see how this Fixes commit is related to OHCI OMAP? A. > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > --- > Changes in version 2: > - refreshed the patch. > > drivers/usb/host/ohci-omap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > index ded9738392e4..45dcf8292072 100644 > --- a/drivers/usb/host/ohci-omap.c > +++ b/drivers/usb/host/ohci-omap.c > @@ -306,7 +306,7 @@ static int ohci_hcd_omap_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - retval = -ENXIO; > + retval = irq; > goto err3; > } > retval = usb_add_hcd(hcd, irq, 0); > -- > 2.26.3 >
Hello! On 12/8/21 10:53 PM, Aaro Koskinen wrote: >> The driver overrides the error codes returned by platform_get_irq() to >> -ENXIO for some strange reason, so if it returns -EPROBE_DEFER, the driver >> will fail the probe permanently instead of the deferred probing. Switch to >> propagating the error codes upstream. >> >> Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008") > > I don't see how this Fixes commit is related to OHCI OMAP? Argh, I missed this! :-( The whole series should be discarded, as the patch #8 also doesn't have the valid Fixes: tag, and I missed to add Alan's ACKs to patches #4..#9 too... :-/ > A. > >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c index ded9738392e4..45dcf8292072 100644 --- a/drivers/usb/host/ohci-omap.c +++ b/drivers/usb/host/ohci-omap.c @@ -306,7 +306,7 @@ static int ohci_hcd_omap_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - retval = -ENXIO; + retval = irq; goto err3; } retval = usb_add_hcd(hcd, irq, 0);
The driver overrides the error codes returned by platform_get_irq() to -ENXIO for some strange reason, so if it returns -EPROBE_DEFER, the driver will fail the probe permanently instead of the deferred probing. Switch to propagating the error codes upstream. Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008") Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- Changes in version 2: - refreshed the patch. drivers/usb/host/ohci-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)