| Message ID | E1mucmf-00EyCl-KA@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [net-next,1/5] net: phylink: add legacy_pre_march2020 indicator | expand |
This series was incorrectly threaded to its cover letter; the patches have now been re-sent with the correct message-ID for their cover letter. Sadly, this mistake was not obvious until I looked at patchwork to work out why they haven't been applied yet. On Tue, Dec 07, 2021 at 03:53:37PM +0000, Russell King (Oracle) wrote: > Add a boolean to phylink_config to indicate whether a driver has not > been updated for the changes in commit 7cceb599d15d ("net: phylink: > avoid mac_config calls"), and thus are reliant on the old behaviour. > > We were currently keying the phylink behaviour on the presence of a > PCS, but this is sub-optimal for modern drivers that may not have a > PCS. > > This commit merely introduces the new flag, but does not add any use, > since we need all legacy drivers to set this flag before it can be > used. Once these legacy drivers have been updated, we can remove this > flag. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > include/linux/phylink.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/phylink.h b/include/linux/phylink.h > index 01224235df0f..d005b8e36048 100644 > --- a/include/linux/phylink.h > +++ b/include/linux/phylink.h > @@ -84,6 +84,8 @@ enum phylink_op_type { > * struct phylink_config - PHYLINK configuration structure > * @dev: a pointer to a struct device associated with the MAC > * @type: operation type of PHYLINK instance > + * @legacy_pre_march2020: driver has not been updated for March 2020 updates > + * (See commit 7cceb599d15d ("net: phylink: avoid mac_config calls") > * @pcs_poll: MAC PCS cannot provide link change interrupt > * @poll_fixed_state: if true, starts link_poll, > * if MAC link is at %MLO_AN_FIXED mode. > @@ -97,6 +99,7 @@ enum phylink_op_type { > struct phylink_config { > struct device *dev; > enum phylink_op_type type; > + bool legacy_pre_march2020; > bool pcs_poll; > bool poll_fixed_state; > bool ovr_an_inband; > -- > 2.30.2 > >
On Thu, 9 Dec 2021 13:14:55 +0000 Russell King (Oracle) wrote: > This series was incorrectly threaded to its cover letter; the patches > have now been re-sent with the correct message-ID for their cover > letter. Sadly, this mistake was not obvious until I looked at patchwork > to work out why they haven't been applied yet. Hm, I think they were showing up fine in patchwork, I just didn't get to them, yet. I'll apply as soon as I'm done with the weekly PR.
On Thu, Dec 09, 2021 at 07:20:18AM -0800, Jakub Kicinski wrote: > On Thu, 9 Dec 2021 13:14:55 +0000 Russell King (Oracle) wrote: > > This series was incorrectly threaded to its cover letter; the patches > > have now been re-sent with the correct message-ID for their cover > > letter. Sadly, this mistake was not obvious until I looked at patchwork > > to work out why they haven't been applied yet. > > Hm, I think they were showing up fine in patchwork, I just didn't > get to them, yet. I'll apply as soon as I'm done with the weekly PR. Yes, they're in patchwork, but patchwork is saying "no cover letter" for them, which is what alerted me to the problem. E.g. https://patchwork.kernel.org/project/netdevbpf/patch/E1mucmu-00EyD4-Vy@rmk-PC.armlinux.org.uk/ Context Check Description ... netdev/cover_letter warning Series does not have a cover letter
On Thu, 9 Dec 2021 15:31:06 +0000 Russell King (Oracle) wrote: > On Thu, Dec 09, 2021 at 07:20:18AM -0800, Jakub Kicinski wrote: > > On Thu, 9 Dec 2021 13:14:55 +0000 Russell King (Oracle) wrote: > > > This series was incorrectly threaded to its cover letter; the patches > > > have now been re-sent with the correct message-ID for their cover > > > letter. Sadly, this mistake was not obvious until I looked at patchwork > > > to work out why they haven't been applied yet. > > > > Hm, I think they were showing up fine in patchwork, I just didn't > > get to them, yet. I'll apply as soon as I'm done with the weekly PR. > > Yes, they're in patchwork, but patchwork is saying "no cover letter" for > them, which is what alerted me to the problem. E.g. > > https://patchwork.kernel.org/project/netdevbpf/patch/E1mucmu-00EyD4-Vy@rmk-PC.armlinux.org.uk/ > > Context Check Description > ... > netdev/cover_letter warning Series does not have a cover letter Oh, that, you're right.
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 07 Dec 2021 15:53:37 +0000 you wrote: > Add a boolean to phylink_config to indicate whether a driver has not > been updated for the changes in commit 7cceb599d15d ("net: phylink: > avoid mac_config calls"), and thus are reliant on the old behaviour. > > We were currently keying the phylink behaviour on the presence of a > PCS, but this is sub-optimal for modern drivers that may not have a > PCS. > > [...] Here is the summary with links: - [net-next,1/5] net: phylink: add legacy_pre_march2020 indicator https://git.kernel.org/netdev/net-next/c/3e5b1feccea7 - [net-next,2/5] net: dsa: mark DSA phylink as legacy_pre_march2020 https://git.kernel.org/netdev/net-next/c/0a9f0794d9bd - [net-next,3/5] net: mtk_eth_soc: mark as a legacy_pre_march2020 driver https://git.kernel.org/netdev/net-next/c/b06515367fac - [net-next,4/5] net: phylink: use legacy_pre_march2020 https://git.kernel.org/netdev/net-next/c/001f4261fe4d - [net-next,5/5] net: ag71xx: remove unnecessary legacy methods https://git.kernel.org/netdev/net-next/c/11053047a4af You are awesome, thank you!
diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 01224235df0f..d005b8e36048 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -84,6 +84,8 @@ enum phylink_op_type { * struct phylink_config - PHYLINK configuration structure * @dev: a pointer to a struct device associated with the MAC * @type: operation type of PHYLINK instance + * @legacy_pre_march2020: driver has not been updated for March 2020 updates + * (See commit 7cceb599d15d ("net: phylink: avoid mac_config calls") * @pcs_poll: MAC PCS cannot provide link change interrupt * @poll_fixed_state: if true, starts link_poll, * if MAC link is at %MLO_AN_FIXED mode. @@ -97,6 +99,7 @@ enum phylink_op_type { struct phylink_config { struct device *dev; enum phylink_op_type type; + bool legacy_pre_march2020; bool pcs_poll; bool poll_fixed_state; bool ovr_an_inband;
Add a boolean to phylink_config to indicate whether a driver has not been updated for the changes in commit 7cceb599d15d ("net: phylink: avoid mac_config calls"), and thus are reliant on the old behaviour. We were currently keying the phylink behaviour on the presence of a PCS, but this is sub-optimal for modern drivers that may not have a PCS. This commit merely introduces the new flag, but does not add any use, since we need all legacy drivers to set this flag before it can be used. Once these legacy drivers have been updated, we can remove this flag. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- include/linux/phylink.h | 3 +++ 1 file changed, 3 insertions(+)