diff mbox series

Input: goodix - Fix memory leak in goodix_firmware_upload

Message ID 20211208173321.26659-1-jose.exposito89@gmail.com (mailing list archive)
State Accepted
Commit 3fd6e12a401ead0345e4b7e6a73e117f0713e0c1
Headers show
Series Input: goodix - Fix memory leak in goodix_firmware_upload | expand

Commit Message

José Expósito Dec. 8, 2021, 5:33 p.m. UTC 
Addresses-Coverity-ID: 1493934 ("Resource leak")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
 drivers/input/touchscreen/goodix_fwupload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Dec. 10, 2021, 5:19 a.m. UTC | #1 
On Wed, Dec 08, 2021 at 06:33:21PM +0100, José Expósito wrote:
> Addresses-Coverity-ID: 1493934 ("Resource leak")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/goodix_fwupload.c b/drivers/input/touchscreen/goodix_fwupload.c
index c1e7a2413078..191d4f38d991 100644
--- a/drivers/input/touchscreen/goodix_fwupload.c
+++ b/drivers/input/touchscreen/goodix_fwupload.c
@@ -207,7 +207,7 @@  static int goodix_firmware_upload(struct goodix_ts_data *ts)
 
 	error = goodix_reset_no_int_sync(ts);
 	if (error)
-		return error;
+		goto release;
 
 	error = goodix_enter_upload_mode(ts->client);
 	if (error)