| Message ID | 20211202205855.76946-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1,1/1] can: mcp251x: Get rid of duplicate of_node assignment | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > GPIO library does copy the of_node from the parent device of > the GPIO chip, there is no need to repeat this in the individual > drivers. Remove assignment here. > > For the details one may look into the of_gpio_dev_init() implementation. Marc, what do you think about this change?
On 09.12.2021 13:58:40, Andy Shevchenko wrote: > On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove assignment here. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > Marc, what do you think about this change? LGTM, added to linux-can-next/testing. regards, Marc
On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote: > On 09.12.2021 13:58:40, Andy Shevchenko wrote: > > On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: ... > > Marc, what do you think about this change? > > LGTM, added to linux-can-next/testing. Thanks for applying this and hi311x patches!
On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote: > On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote: > > On 09.12.2021 13:58:40, Andy Shevchenko wrote: > > > On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > > ... > > > > Marc, what do you think about this change? > > > > LGTM, added to linux-can-next/testing. > > Thanks for applying this and hi311x patches! Can we have a chance to see it in the v5.17-rc1?
On 05.01.2022 16:21:13, Andy Shevchenko wrote: > On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote: > > On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote: > > > On 09.12.2021 13:58:40, Andy Shevchenko wrote: > > > > On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > > > > ... > > > > > > Marc, what do you think about this change? > > > > > > LGTM, added to linux-can-next/testing. > > > > Thanks for applying this and hi311x patches! > > Can we have a chance to see it in the v5.17-rc1? Yes: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105 'about to send that PR. regards, Marc
On Wed, Jan 05, 2022 at 03:34:48PM +0100, Marc Kleine-Budde wrote: > On 05.01.2022 16:21:13, Andy Shevchenko wrote: > > On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote: > > > On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote: > > > > On 09.12.2021 13:58:40, Andy Shevchenko wrote: > > > > > On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote: > > > > > > ... > > > > > > > > Marc, what do you think about this change? > > > > > > > > LGTM, added to linux-can-next/testing. > > > > > > Thanks for applying this and hi311x patches! > > > > Can we have a chance to see it in the v5.17-rc1? > > Yes: > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105 > > 'about to send that PR. Cool, thanks! Happy new year!
On 05.01.2022 16:47:25, Andy Shevchenko wrote: > > > Can we have a chance to see it in the v5.17-rc1? > > > > Yes: > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105 > > > > 'about to send that PR. > > Cool, thanks! Happy new year! Thanks. Happy new year, too! regards, Marc
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index 0579ab74f728..0cec808e8727 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -600,9 +600,6 @@ static int mcp251x_gpio_setup(struct mcp251x_priv *priv) gpio->ngpio = ARRAY_SIZE(mcp251x_gpio_names); gpio->names = mcp251x_gpio_names; gpio->can_sleep = true; -#ifdef CONFIG_OF_GPIO - gpio->of_node = priv->spi->dev.of_node; -#endif return devm_gpiochip_add_data(&priv->spi->dev, gpio, priv); }
GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here. For the details one may look into the of_gpio_dev_init() implementation. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/can/spi/mcp251x.c | 3 --- 1 file changed, 3 deletions(-)