| Message ID | 20210915223117.7857-2-jitao.shi@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | force hsa hbp hfp packets multiple of lanenum to avoid screen shift | expand |
Hi, Jitao: Jitao Shi <jitao.shi@mediatek.com> 於 2021年9月16日 週四 上午6:31寫道： > > Some DSI devices reqire the hs packet starting and ending > at same time on all dsi lanes. So use a flag to those devices. > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > --- > include/drm/drm_mipi_dsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index af7ba8071eb0..8e8563792682 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { > * @lp_rate: maximum lane frequency for low power mode in hertz, this should > * be set to the real limits of the hardware, zero is only accepted for > * legacy drivers > + * @hs_packet_end_aligned: transfer dsi hs packet ending aligned > */ > struct mipi_dsi_device { > struct mipi_dsi_host *host; > @@ -189,6 +190,7 @@ struct mipi_dsi_device { > unsigned long mode_flags; > unsigned long hs_rate; > unsigned long lp_rate; > + bool hs_packet_end_aligned; > }; > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:" > -- > 2.25.1
Hi sirs Pls help to review this change. Best Regards Jitao. On Tue, 2021-10-05 at 07:53 +0800, Chun-Kuang Hu wrote: > Hi, Jitao: > > Jitao Shi <jitao.shi@mediatek.com> 於 2021年9月16日 週四 上午6:31寫道： > > > > Some DSI devices reqire the hs packet starting and ending > > at same time on all dsi lanes. So use a flag to those devices. > > > > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > --- > > include/drm/drm_mipi_dsi.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/drm/drm_mipi_dsi.h > > b/include/drm/drm_mipi_dsi.h > > index af7ba8071eb0..8e8563792682 100644 > > --- a/include/drm/drm_mipi_dsi.h > > +++ b/include/drm/drm_mipi_dsi.h > > @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { > > * @lp_rate: maximum lane frequency for low power mode in hertz, > > this should > > * be set to the real limits of the hardware, zero is only > > accepted for > > * legacy drivers > > + * @hs_packet_end_aligned: transfer dsi hs packet ending aligned > > */ > > struct mipi_dsi_device { > > struct mipi_dsi_host *host; > > @@ -189,6 +190,7 @@ struct mipi_dsi_device { > > unsigned long mode_flags; > > unsigned long hs_rate; > > unsigned long lp_rate; > > + bool hs_packet_end_aligned; > > }; > > > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:" > > -- > > 2.25.1
Hi, Dave & Daniel: This patch looks good to me, how do you think about it? Regards, Chun-Kuang. Jitao Shi <jitao.shi@mediatek.com> 於 2021年11月4日 週四 上午11:36寫道： > > Hi sirs > > Pls help to review this change. > > Best Regards > Jitao. > > On Tue, 2021-10-05 at 07:53 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi <jitao.shi@mediatek.com> 於 2021年9月16日 週四 上午6:31寫道： > > > > > > Some DSI devices reqire the hs packet starting and ending > > > at same time on all dsi lanes. So use a flag to those devices. > > > > > > > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > > --- > > > include/drm/drm_mipi_dsi.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/include/drm/drm_mipi_dsi.h > > > b/include/drm/drm_mipi_dsi.h > > > index af7ba8071eb0..8e8563792682 100644 > > > --- a/include/drm/drm_mipi_dsi.h > > > +++ b/include/drm/drm_mipi_dsi.h > > > @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { > > > * @lp_rate: maximum lane frequency for low power mode in hertz, > > > this should > > > * be set to the real limits of the hardware, zero is only > > > accepted for > > > * legacy drivers > > > + * @hs_packet_end_aligned: transfer dsi hs packet ending aligned > > > */ > > > struct mipi_dsi_device { > > > struct mipi_dsi_host *host; > > > @@ -189,6 +190,7 @@ struct mipi_dsi_device { > > > unsigned long mode_flags; > > > unsigned long hs_rate; > > > unsigned long lp_rate; > > > + bool hs_packet_end_aligned; > > > }; > > > > > > #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:" > > > -- > > > 2.25.1
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index af7ba8071eb0..8e8563792682 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -177,6 +177,7 @@ struct mipi_dsi_device_info { * @lp_rate: maximum lane frequency for low power mode in hertz, this should * be set to the real limits of the hardware, zero is only accepted for * legacy drivers + * @hs_packet_end_aligned: transfer dsi hs packet ending aligned */ struct mipi_dsi_device { struct mipi_dsi_host *host; @@ -189,6 +190,7 @@ struct mipi_dsi_device { unsigned long mode_flags; unsigned long hs_rate; unsigned long lp_rate; + bool hs_packet_end_aligned; }; #define MIPI_DSI_MODULE_PREFIX "mipi-dsi:"
Some DSI devices reqire the hs packet starting and ending at same time on all dsi lanes. So use a flag to those devices. Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> --- include/drm/drm_mipi_dsi.h | 2 ++ 1 file changed, 2 insertions(+)