diff mbox series

drm/i915: Don't leak the capture list items

Message ID 20211209141304.393479-1-thomas.hellstrom@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Don't leak the capture list items | expand

Commit Message

Thomas Hellstrom Dec. 9, 2021, 2:13 p.m. UTC 
When we recently converted the capture code to use vma snapshots,
we forgot to free the struct i915_capture_list list items after use.

Fix that by bringing back a kfree.

Fixes: ff20afc4cee7 ("drm/i915: Update error capture code to avoid using the current vma state")
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_request.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Matthew Auld Dec. 9, 2021, 5:28 p.m. UTC | #1 
On 09/12/2021 14:13, Thomas Hellström wrote:
> When we recently converted the capture code to use vma snapshots,
> we forgot to free the struct i915_capture_list list items after use.
> 
> Fix that by bringing back a kfree.
> 
> Fixes: ff20afc4cee7 ("drm/i915: Update error capture code to avoid using the current vma state")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Thomas Hellstrom Dec. 13, 2021, 9:50 a.m. UTC | #2 
On Sat, 2021-12-11 at 09:49 +0000, Patchwork wrote:
> Patch Details
> Series:drm/i915: Don't leak the capture list items
> (rev2)URL:https://patchwork.freedesktop.org/series/97804/State:failur
> e
> Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21820/index.html
> CI Bug Log - changes from CI_DRM_10988_full -> Patchwork_21820_fullSummaryFAILURE
> Serious unknown changes coming with Patchwork_21820_full absolutely
> need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_21820_full, please notify your bug team to
> allow them
> to document this new failure mode, which will reduce false positives
> in CI.
> Participating hosts (10 -> 10)No changes in participating hosts
> Possible new issuesHere are the unknown changes that may have been introduced in
> Patchwork_21820_full:
> IGT changesPossible regressions * igt@kms_big_fb@linear-64bpp-rotate-180:shard-iclb: PASS -> FAIL
>  * igt@kms_plane_cursor@pipe-a-viewport-size-64:
>     - shard-glk: PASS -> FAIL


Lakshmi,
The above errors are unrelated.

Thanks,
Thomas
Vudum, Lakshminarayana Dec. 13, 2021, 5:22 p.m. UTC | #3 
Regressions are related to
https://gitlab.freedesktop.org/drm/intel/-/issues/4729
igt@kms_plane_cursor@.*<mailto:igt@kms_plane_cursor@.*> - fail - Failed assertion: !mismatch || igt_skip_crc_compare

https://gitlab.freedesktop.org/drm/intel/-/issues/3653
igt@kms_big_fb.*<mailto:igt@kms_big_fb.*> - fail - Failed assertion: !mismatch || igt_skip_crc_compare

Patch is re-reported.

Thanks,
Lakshmi.
From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Sent: Monday, December 13, 2021 1:51 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Don't leak the capture list items (rev2)

On Sat, 2021-12-11 at 09:49 +0000, Patchwork wrote:
Patch Details
Series:

drm/i915: Don't leak the capture list items (rev2)

URL:

https://patchwork.freedesktop.org/series/97804/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21820/index.html

CI Bug Log - changes from CI_DRM_10988_full -> Patchwork_21820_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_21820_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21820_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (10 -> 10)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_21820_full:

IGT changes
Possible regressions

  *   igt@kms_big_fb@linear-64bpp-rotate-180:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-iclb2/igt@kms_big_fb@linear-64bpp-rotate-180.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21820/shard-iclb6/igt@kms_big_fb@linear-64bpp-rotate-180.html>

  *   igt@kms_plane_cursor@pipe-a-viewport-size-64:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10988/shard-glk1/igt@kms_plane_cursor@pipe-a-viewport-size-64.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21820/shard-glk3/igt@kms_plane_cursor@pipe-a-viewport-size-64.html>


Lakshmi,
The above errors are unrelated.

Thanks,
Thomas
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 471cde0e9883..fe682b6902aa 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -307,6 +307,7 @@  void i915_request_free_capture_list(struct i915_capture_list *capture)
 		struct i915_capture_list *next = capture->next;
 
 		i915_vma_snapshot_put(capture->vma_snapshot);
+		kfree(capture);
 		capture = next;
 	}
 }