diff mbox series

ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors

Message ID 20211206004334.4169408-1-linus.walleij@linaro.org (mailing list archive)
State Accepted
Commit 4754eab7e5a78bdefe7a960c5c260c95ebbb5fa6
Headers show
Series ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors | expand

Commit Message

Linus Walleij Dec. 6, 2021, 12:43 a.m. UTC 
From: Christian Lamparter <chunkeey@gmail.com>

Steven Maddox reported in the OpenWrt bugzilla, that his
RaidSonic IB-NAS4220-B was no longer booting with the new
OpenWrt 21.02 (uses linux 5.10's device-tree). However, it was
working with the previous OpenWrt 19.07 series (uses 4.14).

|[    5.548038] No RedBoot partition table detected in 30000000.flash
|[    5.618553] Searching for RedBoot partition table in 30000000.flash at offset 0x0
|[    5.739093] No RedBoot partition table detected in 30000000.flash
|...
|[    7.039504] Waiting for root device /dev/mtdblock3...

The provided bootlog shows that the RedBoot partition parser was
looking for the partition table "at offset 0x0". Which is strange
since the comment in the device-tree says it should be at 0xfe0000.

Further digging on the internet led to a review site that took
some useful PCB pictures of their review unit back in February 2009.
Their picture shows a Spansion S29GL128N11TFI01 flash chip.

From Spansion's Datasheet:
"S29GL128N: One hundred twenty-eight 64 Kword (128 Kbyte) sectors"
Steven also provided a "cat /sys/class/mtd/mtd0/erasesize" from his
unit: "131072".

With the 128 KiB Sector/Erasesize in mind. This patch changes the
fis-index-block property to (0xfe0000 / 0x20000) = 0x7f.

Fixes: b5a923f8c739 ("ARM: dts: gemini: Switch to redboot partition parsing")
Bugzilla: https://bugs.openwrt.org/index.php?do=details&task_id=4137
Reported-by: Steven Maddox <s.maddox@lantizia.me.uk>
Tested-by: Steven Maddox <s.maddox@lantizia.me.uk>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi ARM SoC maintainers, please apply this directly for fixes.
---
 arch/arm/boot/dts/gemini-nas4220b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+linux-soc@kernel.org Dec. 13, 2021, 11:30 p.m. UTC | #1 
Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon,  6 Dec 2021 01:43:34 +0100 you wrote:
> From: Christian Lamparter <chunkeey@gmail.com>
> 
> Steven Maddox reported in the OpenWrt bugzilla, that his
> RaidSonic IB-NAS4220-B was no longer booting with the new
> OpenWrt 21.02 (uses linux 5.10's device-tree). However, it was
> working with the previous OpenWrt 19.07 series (uses 4.14).
> 
> [...]

Here is the summary with links:
  - ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors
    https://git.kernel.org/soc/soc/c/4754eab7e5a7

You are awesome, thank you!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/gemini-nas4220b.dts b/arch/arm/boot/dts/gemini-nas4220b.dts
index 13112a8a5dd8..6544c730340f 100644
--- a/arch/arm/boot/dts/gemini-nas4220b.dts
+++ b/arch/arm/boot/dts/gemini-nas4220b.dts
@@ -84,7 +84,7 @@  flash@30000000 {
 			partitions {
 				compatible = "redboot-fis";
 				/* Eraseblock at 0xfe0000 */
-				fis-index-block = <0x1fc>;
+				fis-index-block = <0x7f>;
 			};
 		};