mbox series

[v5,0/2] wilc1000: Add reset/enable GPIO support to SPI driver

Message ID 20211215030501.3779911-1-davidm@egauge.net (mailing list archive)
Headers show
Series wilc1000: Add reset/enable GPIO support to SPI driver | expand

Message

David Mosberger-Tang Dec. 15, 2021, 3:05 a.m. UTC 
The only change in this version is to fix a dt_binding_check error by
including <dt-bindings/gpio/gpio.h> in microchip,wilc1000.yaml.

David Mosberger-Tang (2):
  wilc1000: Add reset/enable GPIO support to SPI driver
  wilc1000: Document enable-gpios and reset-gpios properties

 .../net/wireless/microchip,wilc1000.yaml      | 19 ++++++
 drivers/net/wireless/microchip/wilc1000/spi.c | 58 ++++++++++++++++++-
 .../net/wireless/microchip/wilc1000/wlan.c    |  2 +-
 3 files changed, 75 insertions(+), 4 deletions(-)

Comments

Claudiu Beznea Dec. 15, 2021, 5:37 a.m. UTC | #1 
On 15.12.2021 05:05, David Mosberger-Tang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The only change in this version is to fix a dt_binding_check error by
> including <dt-bindings/gpio/gpio.h> in microchip,wilc1000.yaml.

For future patches, here you should have the full changelog b/w version,
something like:

Changes in v5:
- this
- that
- etc

Changes in v4:
- this, that

...

Changes in v2:
- this, that

> 
> David Mosberger-Tang (2):
>   wilc1000: Add reset/enable GPIO support to SPI driver
>   wilc1000: Document enable-gpios and reset-gpios properties
> 
>  .../net/wireless/microchip,wilc1000.yaml      | 19 ++++++
>  drivers/net/wireless/microchip/wilc1000/spi.c | 58 ++++++++++++++++++-
>  .../net/wireless/microchip/wilc1000/wlan.c    |  2 +-
>  3 files changed, 75 insertions(+), 4 deletions(-)
> 
> --
> 2.25.1
>
David Mosberger-Tang Dec. 15, 2021, 2:48 p.m. UTC | #2 
On Wed, 2021-12-15 at 05:37 +0000, Claudiu.Beznea@microchip.com wrote:
> On 15.12.2021 05:05, David Mosberger-Tang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > The only change in this version is to fix a dt_binding_check error by
> > including <dt-bindings/gpio/gpio.h> in microchip,wilc1000.yaml.
> 
> For future patches, here you should have the full changelog b/w version,
> something like:
> 
> Changes in v5:
> - this
> - that
> - etc
> 
> Changes in v4:
> - this, that
> 
> ...
> 
> Changes in v2:
> - this, that

Sure, I can do that going forward.

Thanks,

  --david
Claudiu Beznea Dec. 16, 2021, 8:03 a.m. UTC | #3 
On 15.12.2021 05:05, David Mosberger-Tang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The only change in this version is to fix a dt_binding_check error by
> including <dt-bindings/gpio/gpio.h> in microchip,wilc1000.yaml.
> 
> David Mosberger-Tang (2):
>   wilc1000: Add reset/enable GPIO support to SPI driver
>   wilc1000: Document enable-gpios and reset-gpios properties
> 
>  .../net/wireless/microchip,wilc1000.yaml      | 19 ++++++
>  drivers/net/wireless/microchip/wilc1000/spi.c | 58 ++++++++++++++++++-
>  .../net/wireless/microchip/wilc1000/wlan.c    |  2 +-
>  3 files changed, 75 insertions(+), 4 deletions(-)
> 
> --
> 2.25.1
> 

Comments are clarified, you can add my:

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>