[0/3] drm: rcar-du: Add missing dependencies

Message

Geert Uytterhoeven Dec. 15, 2021, 9:27 a.m. UTC

Hi Laurent, Kieran, et al,

This patch series adds missing dependencies to Kconfig symbols related
to the R-Car Display Unit.  These dependencies prevent asking the user
about R-Car display drivers when configuring a kernel without Renesas
SoC support, or when the answer wouldn't have any impact on the kernel
build.

Thanks for your comments!

Geert Uytterhoeven (3):
  drm: rcar-du: DRM_RCAR_DW_HDMI should depend on ARCH_RENESAS
  drm: rcar-du: DRM_RCAR_USE_LVDS should depend on DRM_RCAR_DU
  drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS

 drivers/gpu/drm/rcar-du/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart Dec. 15, 2021, 9:42 a.m. UTC | #1

Hi Geert,

Thank you for the patches.

On Wed, Dec 15, 2021 at 10:27:44AM +0100, Geert Uytterhoeven wrote:
> 	Hi Laurent, Kieran, et al,
> 
> This patch series adds missing dependencies to Kconfig symbols related
> to the R-Car Display Unit.  These dependencies prevent asking the user
> about R-Car display drivers when configuring a kernel without Renesas
> SoC support, or when the answer wouldn't have any impact on the kernel
> build.

Won't this have an impact when someone will regenerate an ARM64
defconfig, given that we want to keep those options enabled in
arch/arm64/configs/defconfig ?

> Thanks for your comments!
> 
> Geert Uytterhoeven (3):
>   drm: rcar-du: DRM_RCAR_DW_HDMI should depend on ARCH_RENESAS
>   drm: rcar-du: DRM_RCAR_USE_LVDS should depend on DRM_RCAR_DU
>   drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS
> 
>  drivers/gpu/drm/rcar-du/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Geert Uytterhoeven Dec. 15, 2021, 10:12 a.m. UTC | #2

Hi Laurent,

On Wed, Dec 15, 2021 at 10:43 AM Laurent Pinchart
<[e-mail]> wrote:
> On Wed, Dec 15, 2021 at 10:27:44AM +0100, Geert Uytterhoeven wrote:
> > This patch series adds missing dependencies to Kconfig symbols related
> > to the R-Car Display Unit.  These dependencies prevent asking the user
> > about R-Car display drivers when configuring a kernel without Renesas
> > SoC support, or when the answer wouldn't have any impact on the kernel
> > build.
>
> Won't this have an impact when someone will regenerate an ARM64
> defconfig, given that we want to keep those options enabled in
> arch/arm64/configs/defconfig ?

arch/arm64/configs/defconfig has CONFIG_ARCH_RENESAS=y, so it is
not impacted.

> > Geert Uytterhoeven (3):
> >   drm: rcar-du: DRM_RCAR_DW_HDMI should depend on ARCH_RENESAS
> >   drm: rcar-du: DRM_RCAR_USE_LVDS should depend on DRM_RCAR_DU
> >   drm: rcar-du: DRM_RCAR_MIPI_DSI should depend on ARCH_RENESAS

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds