| Message ID | 20211209031424.17842-1-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] usb: mtu3: fix interval value for intr and isoc | expand |
On Thu, Dec 09, 2021 at 11:14:22AM +0800, Chunfeng Yun wrote: > Use the Interval value from isoc/intr endpoint descriptor, no need > minus one. But the original code doesn't cause transfer error for > normal cases, due to the interval is less than the host request. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) What commit does this fix?
On Mon, 2021-12-13 at 15:20 +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 09, 2021 at 11:14:22AM +0800, Chunfeng Yun wrote: > > Use the Interval value from isoc/intr endpoint descriptor, no need > > minus one. But the original code doesn't cause transfer error for > > normal cases, due to the interval is less than the host request. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > What commit does this fix? The interval between transfers is less than the Interval value, I add it in commit massage when send out v2. Thanks
diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index a9a65b4bbfed..c51be015345b 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -77,7 +77,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_int(desc) || usb_endpoint_xfer_isoc(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); if (usb_endpoint_xfer_isoc(desc) && comp_desc) mult = comp_desc->bmAttributes; } @@ -89,7 +89,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_isoc(desc) || usb_endpoint_xfer_int(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); mult = usb_endpoint_maxp_mult(desc) - 1; } break;
Use the Interval value from isoc/intr endpoint descriptor, no need minus one. But the original code doesn't cause transfer error for normal cases, due to the interval is less than the host request. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)