mbox series

[v3,0/3] drm/simpledrm: Apple M1 / DT platform support fixes

Message ID 20211212062407.138309-1-marcan@marcan.st (mailing list archive)
Headers show
Series drm/simpledrm: Apple M1 / DT platform support fixes | expand

Message

Hector Martin Dec. 12, 2021, 6:24 a.m. UTC
Hi DRM folks,

This short series makes simpledrm work on Apple M1 (including Pro/Max)
platforms the way simplefb already does, by adding XRGB2101010 support
and making it bind to framebuffers in /chosen the same way simplefb
does.

This avoids breaking the bootloader-provided framebuffer console when
simpledrm is selected to replace simplefb, as these FBs always seem to
be 10-bit (at least when a real screen is attached).

Changes since v2:
- Made 10-bit conversion code fill the LSBs
- Added ARGB2101010 to supported formats list
- Simplified OF core code per review feedback
Hector Martin (3):
  of: Move simple-framebuffer device handling from simplefb to of
  drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_toio()
  drm/simpledrm: Add [AX]RGB2101010 formats

 drivers/gpu/drm/drm_format_helper.c | 64 +++++++++++++++++++++++++++++
 drivers/gpu/drm/tiny/simpledrm.c    |  4 +-
 drivers/of/platform.c               |  4 ++
 drivers/video/fbdev/simplefb.c      | 21 +---------
 include/drm/drm_format_helper.h     |  3 ++
 5 files changed, 74 insertions(+), 22 deletions(-)

Comments

Thomas Zimmermann Dec. 15, 2021, 1:29 p.m. UTC | #1
Hi

Am 12.12.21 um 07:24 schrieb Hector Martin:
> Hi DRM folks,
> 
> This short series makes simpledrm work on Apple M1 (including Pro/Max)
> platforms the way simplefb already does, by adding XRGB2101010 support
> and making it bind to framebuffers in /chosen the same way simplefb
> does.
> 
> This avoids breaking the bootloader-provided framebuffer console when
> simpledrm is selected to replace simplefb, as these FBs always seem to
> be 10-bit (at least when a real screen is attached).

If there are no further comments, I'm going to apply the series to 
drm-misc-next.

Best regards
Thomas

> 
> Changes since v2:
> - Made 10-bit conversion code fill the LSBs
> - Added ARGB2101010 to supported formats list
> - Simplified OF core code per review feedback
> Hector Martin (3):
>    of: Move simple-framebuffer device handling from simplefb to of
>    drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_toio()
>    drm/simpledrm: Add [AX]RGB2101010 formats
> 
>   drivers/gpu/drm/drm_format_helper.c | 64 +++++++++++++++++++++++++++++
>   drivers/gpu/drm/tiny/simpledrm.c    |  4 +-
>   drivers/of/platform.c               |  4 ++
>   drivers/video/fbdev/simplefb.c      | 21 +---------
>   include/drm/drm_format_helper.h     |  3 ++
>   5 files changed, 74 insertions(+), 22 deletions(-)
>
Thomas Zimmermann Dec. 16, 2021, 10:13 a.m. UTC | #2
Hi

Am 15.12.21 um 14:29 schrieb Thomas Zimmermann:
> Hi
> 
> Am 12.12.21 um 07:24 schrieb Hector Martin:
>> Hi DRM folks,
>>
>> This short series makes simpledrm work on Apple M1 (including Pro/Max)
>> platforms the way simplefb already does, by adding XRGB2101010 support
>> and making it bind to framebuffers in /chosen the same way simplefb
>> does.
>>
>> This avoids breaking the bootloader-provided framebuffer console when
>> simpledrm is selected to replace simplefb, as these FBs always seem to
>> be 10-bit (at least when a real screen is attached).
> 
> If there are no further comments, I'm going to apply the series to 
> drm-misc-next.

I've added the series.

Best regards
Thomas

> 
> Best regards
> Thomas
> 
>>
>> Changes since v2:
>> - Made 10-bit conversion code fill the LSBs
>> - Added ARGB2101010 to supported formats list
>> - Simplified OF core code per review feedback
>> Hector Martin (3):
>>    of: Move simple-framebuffer device handling from simplefb to of
>>    drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_toio()
>>    drm/simpledrm: Add [AX]RGB2101010 formats
>>
>>   drivers/gpu/drm/drm_format_helper.c | 64 +++++++++++++++++++++++++++++
>>   drivers/gpu/drm/tiny/simpledrm.c    |  4 +-
>>   drivers/of/platform.c               |  4 ++
>>   drivers/video/fbdev/simplefb.c      | 21 +---------
>>   include/drm/drm_format_helper.h     |  3 ++
>>   5 files changed, 74 insertions(+), 22 deletions(-)
>>
>