| Message ID | 4f409ac939e260a4657a0e6e6518ef8736527822.1639744468.git.geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: timer: sifive, clint: Miscellaneous improvements | expand |
On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems". As the architectural maximum > is 4095 interrupts, using that as the limit would be unpractical. Hence > limit it to 10 interrupts (two interrupts for a system management core, > and two interrupts per core for other cores). This should be sufficient > for now, and the limit can always be increased when the need arises. Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 10 > > additionalProperties: false > > -- > 2.25.1 >
On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote: > > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > The number of interrupts lacks an upper bound, thus assuming one, > > causing properly grouped "interrupts-extended" properties to be flagged > > as an error by "make dtbs_check". > > > > Fix this by adding the missing "maxItems". As the architectural maximum > > is 4095 interrupts, using that as the limit would be unpractical. Hence > > limit it to 10 interrupts (two interrupts for a system management core, > > and two interrupts per core for other cores). This should be sufficient > > for now, and the limit can always be increased when the need arises. > > Same comment as the PLIC DT binding patch. > > The "maxItems" should represent CLINT spec constraints so > please don't add any synthetic value here. I agree. Geert, are you going to respin these? Rob
Hi Rob, On Wed, Jan 26, 2022 at 8:37 PM Rob Herring <robh+dt@kernel.org> wrote: > On Fri, Dec 17, 2021 at 6:48 AM Anup Patel <anup@brainfault.org> wrote: > > On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > The number of interrupts lacks an upper bound, thus assuming one, > > > causing properly grouped "interrupts-extended" properties to be flagged > > > as an error by "make dtbs_check". > > > > > > Fix this by adding the missing "maxItems". As the architectural maximum > > > is 4095 interrupts, using that as the limit would be unpractical. Hence > > > limit it to 10 interrupts (two interrupts for a system management core, > > > and two interrupts per core for other cores). This should be sufficient > > > for now, and the limit can always be increased when the need arises. > > > > Same comment as the PLIC DT binding patch. > > > > The "maxItems" should represent CLINT spec constraints so > > please don't add any synthetic value here. > > I agree. > > Geert, are you going to respin these? Sure, will do, now we have an agreement. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 10 additionalProperties: false