| Message ID | 20211218143641.19372-1-alexander.stein@mailbox.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] dt-bindings: display: meson-vpu: Add missing amlogic, canvas property | expand |
Hi Alexander, first of all: thank you for working on this! On Sat, Dec 18, 2021 at 3:37 PM Alexander Stein <alexander.stein@mailbox.org> wrote: > > This property was already mentioned in the old textual bindings > amlogic,meson-vpu.txt, but got dropped during conversion. > Adding it back similar to amlogic,gx-vdec.yaml. > > Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to > yaml") Most patches which I have seen don't use a line-break in the "Fixes:" line. Not sure if this is a rule though, so this is just FYI [...] > + amlogic,canvas: > + description: should point to a canvas provider node > + $ref: /schemas/types.yaml#/definitions/phandle This was also marked as a mandatory property in the textual binding. Can you please update the "required" section below and add the property to the example (that last part has been missing in the textual binding)? Thank you and best regards, Martin
diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml index 851cb0781217..65bf6d7ec707 100644 --- a/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml +++ b/Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml @@ -78,6 +78,10 @@ properties: interrupts: maxItems: 1 + amlogic,canvas: + description: should point to a canvas provider node + $ref: /schemas/types.yaml#/definitions/phandle + power-domains: maxItems: 1 description: phandle to the associated power domain
This property was already mentioned in the old textual bindings amlogic,meson-vpu.txt, but got dropped during conversion. Adding it back similar to amlogic,gx-vdec.yaml. Fixes: 6b9ebf1e0e67 ("dt-bindings: display: amlogic, meson-vpu: convert to yaml") Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 4 ++++ 1 file changed, 4 insertions(+)