diff mbox series

[1/2] arm64: dts: rockchip: fix audio-supply for Rock Pi 4

Message ID 20211027143726.165809-1-knaerzche@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: rockchip: fix audio-supply for Rock Pi 4 | expand

Commit Message

Alex Bee Oct. 27, 2021, 2:37 p.m. UTC
As stated in the schematics [1] and [2] P5 the APIO5 domain is supplied
by RK808-D Buck4, which in our case vcc1v8_codec - i.e. a 1.8 V regulator.

Currently only white noise comes from the ES8316's output, which - for
whatever reason - came up only after the the correct switch from i2s0_8ch_bus
to i2s0_2ch_bus for i2s0's pinctrl was done.

Fix this by setting the correct regulator for audio-supply.

[1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf
[2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi_4c_v12_sch_20200620.pdf

Fixes: 1b5715c602fd ("arm64: dts: rockchip: add ROCK Pi 4 DTS support")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stübner Nov. 21, 2021, 6:52 p.m. UTC | #1
On Wed, 27 Oct 2021 16:37:25 +0200, Alex Bee wrote:
> As stated in the schematics [1] and [2] P5 the APIO5 domain is supplied
> by RK808-D Buck4, which in our case vcc1v8_codec - i.e. a 1.8 V regulator.
> 
> Currently only white noise comes from the ES8316's output, which - for
> whatever reason - came up only after the the correct switch from i2s0_8ch_bus
> to i2s0_2ch_bus for i2s0's pinctrl was done.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: fix audio-supply for Rock Pi 4
      commit: 8240e87f16d17a9592c9d67857a3dcdbcb98f10d
[2/2] arm64: dts: rockchip: add interrupt and headphone-detection for Rock Pi4's audio codec
      commit: c681c6fcc5ddfa0492ca015b0bf325cd4881ce07

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 98136c88fa49..6a434be62819 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -502,7 +502,7 @@  &io_domains {
 	status = "okay";
 
 	bt656-supply = <&vcc_3v0>;
-	audio-supply = <&vcc_3v0>;
+	audio-supply = <&vcc1v8_codec>;
 	sdmmc-supply = <&vcc_sdio>;
 	gpio1830-supply = <&vcc_3v0>;
 };