| Message ID | 20211202120758.41478-9-alistair@alistair23.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for the silergy,sy7636a | expand |
Hi Alistair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on lee-mfd/for-mfd-next robh/for-next v5.16-rc3 next-20211203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alistair-Francis/Add-support-for-the-silergy-sy7636a/20211202-201116
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arm-randconfig-c002-20211202 (https://download.01.org/0day-ci/archive/20211205/202112050943.k8t5MaMs-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/690ae9a20c4cbd1aab1695c0ca6c8d7dbe1d51a6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alistair-Francis/Add-support-for-the-silergy-sy7636a/20211202-201116
git checkout 690ae9a20c4cbd1aab1695c0ca6c8d7dbe1d51a6
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/imx7d-remarkable2.dts:258.3-260.5 Properties must precede subnodes
>> FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Alistair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on lee-mfd/for-mfd-next robh/for-next v5.16-rc3 next-20211203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alistair-Francis/Add-support-for-the-silergy-sy7636a/20211202-201116
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arm-randconfig-c002-20211205 (https://download.01.org/0day-ci/archive/20211205/202112051306.WFgQGIPH-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5f1d1854eb1450d352663ee732235893c5782237)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/690ae9a20c4cbd1aab1695c0ca6c8d7dbe1d51a6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alistair-Francis/Add-support-for-the-silergy-sy7636a/20211202-201116
git checkout 690ae9a20c4cbd1aab1695c0ca6c8d7dbe1d51a6
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/imx7d-remarkable2.dts:258.3-260.5 Properties must precede subnodes
FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On Thu, 2 Dec 2021 22:07:58 +1000 Alistair Francis <alistair@alistair23.me> wrote: > Connect the dispaly on the reMarkable2. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 73 +++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index b66d28b30d75..bb0c68d24583 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts [...] > @@ -187,6 +221,45 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > >; > }; > > + pinctrl_lcdif: lcdifgrp { > + fsl,pins = < > + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79 > + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79 > + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79 > + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79 > + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79 > + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79 > + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79 > + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79 > + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79 > + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79 > + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79 > + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79 > + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79 > + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79 > + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79 > + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79 > + > + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79 > + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79 > + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79 > + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79 > + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79 > + > + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79 > + MX7D_PAD_LCD_CLK__LCD_CLK 0x79 > + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x79 > + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x79 > + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x79 > + MX7D_PAD_LCD_RESET__LCD_RESET 0x79 > + >; > + }; shouldn't this belong into the upper list: > + > + fsl,pins = < > + MX7D_PAD_LCD_DATA22__GPIO3_IO27 0x74 > + >; > + }; > + probably some rebase or merge accident. If I submit non-trivial things, I usually apply my patches to a separate git tree and do a final compile, that might help to reduce some trouble. Regards, Andreas
On Mon, Dec 6, 2021 at 7:07 AM Andreas Kemnade <andreas@kemnade.info> wrote: > > On Thu, 2 Dec 2021 22:07:58 +1000 > Alistair Francis <alistair@alistair23.me> wrote: > > > Connect the dispaly on the reMarkable2. > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > > --- > > arch/arm/boot/dts/imx7d-remarkable2.dts | 73 +++++++++++++++++++++++++ > > 1 file changed, 73 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > > index b66d28b30d75..bb0c68d24583 100644 > > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > [...] > > > @@ -187,6 +221,45 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > > >; > > }; > > > > + pinctrl_lcdif: lcdifgrp { > > + fsl,pins = < > > + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79 > > + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79 > > + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79 > > + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79 > > + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79 > > + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79 > > + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79 > > + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79 > > + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79 > > + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79 > > + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79 > > + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79 > > + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79 > > + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79 > > + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79 > > + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79 > > + > > + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79 > > + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79 > > + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79 > > + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79 > > + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79 > > + > > + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79 > > + MX7D_PAD_LCD_CLK__LCD_CLK 0x79 > > + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x79 > > + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x79 > > + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x79 > > + MX7D_PAD_LCD_RESET__LCD_RESET 0x79 > > + >; > > + }; > > shouldn't this belong into the upper list: > > + > > + fsl,pins = < > > + MX7D_PAD_LCD_DATA22__GPIO3_IO27 0x74 > > + >; > > + }; > > + > > probably some rebase or merge accident. If I submit non-trivial things, > I usually apply my patches to a separate git tree and do a final > compile, that might help to reduce some trouble. Yeah, it was a rebase error. I split these patches out from my working tree. Alistair > > Regards, > Andreas
diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts index b66d28b30d75..bb0c68d24583 100644 --- a/arch/arm/boot/dts/imx7d-remarkable2.dts +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts @@ -55,6 +55,16 @@ reg_brcm: regulator-brcm { startup-delay-us = <150>; }; + reg_sdoe: regulator-sdoe { + compatible = "regulator-fixed"; + regulator-name = "SDOE"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&pinctrl_sdoe_reg>; + pinctrl-1 = <&pinctrl_sdoe_reg>; + gpio = <&gpio3 27 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; @@ -63,6 +73,16 @@ wifi_pwrseq: wifi_pwrseq { clocks = <&clks IMX7D_CLKO2_ROOT_DIV>; clock-names = "ext_clock"; }; + + panel { + compatible = "eink,vb3300-kca"; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; }; &clks { @@ -99,6 +119,20 @@ reg_epdpmic: vcom { }; }; +&lcdif { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lcdif>; + lcd-supply = <®_epdpmic>; + lcd2-supply = <®_sdoe>; + status = "okay"; + + port { + display_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; +}; + &snvs_pwrkey { status = "okay"; }; @@ -187,6 +221,45 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f >; }; + pinctrl_lcdif: lcdifgrp { + fsl,pins = < + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79 + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79 + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79 + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79 + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79 + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79 + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79 + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79 + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79 + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79 + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79 + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79 + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79 + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79 + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79 + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79 + + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79 + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79 + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79 + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79 + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79 + + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79 + MX7D_PAD_LCD_CLK__LCD_CLK 0x79 + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x79 + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x79 + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x79 + MX7D_PAD_LCD_RESET__LCD_RESET 0x79 + >; + }; + + fsl,pins = < + MX7D_PAD_LCD_DATA22__GPIO3_IO27 0x74 + >; + }; + pinctrl_uart1: uart1grp { fsl,pins = < MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
Connect the dispaly on the reMarkable2. Signed-off-by: Alistair Francis <alistair@alistair23.me> --- arch/arm/boot/dts/imx7d-remarkable2.dts | 73 +++++++++++++++++++++++++ 1 file changed, 73 insertions(+)