diff mbox series

KVM: arm64: Constify kvm_io_gic_ops

Message ID 20211204213518.83642-1-rikard.falkeborn@gmail.com (mailing list archive)
State New, archived
Headers show
Series KVM: arm64: Constify kvm_io_gic_ops | expand

Commit Message

Rikard Falkeborn Dec. 4, 2021, 9:35 p.m. UTC
The only usage of kvm_io_gic_ops is to make a comparison with its
address and to pass its address to kvm_iodevice_init() which takes a
pointer to const kvm_io_device_ops as input. Make it const to allow the
compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 arch/arm64/kvm/vgic/vgic-mmio.c | 2 +-
 arch/arm64/kvm/vgic/vgic-mmio.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marc Zyngier Dec. 6, 2021, 8:41 a.m. UTC | #1
On Sat, 4 Dec 2021 22:35:18 +0100, Rikard Falkeborn wrote:
> The only usage of kvm_io_gic_ops is to make a comparison with its
> address and to pass its address to kvm_iodevice_init() which takes a
> pointer to const kvm_io_device_ops as input. Make it const to allow the
> compiler to put it in read-only memory.

Applied to next, thanks!

[1/1] KVM: arm64: Constify kvm_io_gic_ops
      commit: 636dcd0204599f94680f8f87b46cef7c66034ac0

Cheers,

	M.
diff mbox series

Patch

diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c b/arch/arm64/kvm/vgic/vgic-mmio.c
index 48c6067fc5ec..7068da080799 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.c
+++ b/arch/arm64/kvm/vgic/vgic-mmio.c
@@ -1050,7 +1050,7 @@  static int dispatch_mmio_write(struct kvm_vcpu *vcpu, struct kvm_io_device *dev,
 	return 0;
 }
 
-struct kvm_io_device_ops kvm_io_gic_ops = {
+const struct kvm_io_device_ops kvm_io_gic_ops = {
 	.read = dispatch_mmio_read,
 	.write = dispatch_mmio_write,
 };
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.h b/arch/arm64/kvm/vgic/vgic-mmio.h
index fefcca2b14dc..3fa696f198a3 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.h
+++ b/arch/arm64/kvm/vgic/vgic-mmio.h
@@ -34,7 +34,7 @@  struct vgic_register_region {
 	};
 };
 
-extern struct kvm_io_device_ops kvm_io_gic_ops;
+extern const struct kvm_io_device_ops kvm_io_gic_ops;
 
 #define VGIC_ACCESS_8bit	1
 #define VGIC_ACCESS_32bit	2