mbox series

[kvm-unit-tests,v9,0/9] MTTCG sanity tests for ARM

Message ID 20211202115352.951548-1-alex.bennee@linaro.org (mailing list archive)
Headers show
Series MTTCG sanity tests for ARM | expand

Message

Alex Bennée Dec. 2, 2021, 11:53 a.m. UTC
Hi,

Not a great deal has changed from the last posting although I have
dropped the additional unittests.cfg in favour of setting "nodefault"
for the tests. Otherwise the clean-ups are mainly textual (removing
printfs, random newlines and cleaning up comments). As usual the
details are in the commits bellow the ---.

I've also tweaked .git/config so get_maintainer.pl should ensure
direct delivery of the patches ;-)

Alex Bennée (9):
  docs: mention checkpatch in the README
  arm/flat.lds: don't drop debug during link
  Makefile: add GNU global tags support
  lib: add isaac prng library from CCAN
  arm/tlbflush-code: TLB flush during code execution
  arm/locking-tests: add comprehensive locking test
  arm/barrier-litmus-tests: add simple mp and sal litmus tests
  arm/run: use separate --accel form
  arm/tcg-test: some basic TCG exercising tests

 arm/run                   |   4 +-
 Makefile                  |   5 +-
 arm/Makefile.arm          |   2 +
 arm/Makefile.arm64        |   2 +
 arm/Makefile.common       |   6 +-
 lib/arm/asm/barrier.h     |  19 ++
 lib/arm64/asm/barrier.h   |  50 +++++
 lib/prng.h                |  82 +++++++
 lib/prng.c                | 162 ++++++++++++++
 arm/flat.lds              |   1 -
 arm/tcg-test-asm.S        | 171 +++++++++++++++
 arm/tcg-test-asm64.S      | 170 ++++++++++++++
 arm/barrier-litmus-test.c | 450 ++++++++++++++++++++++++++++++++++++++
 arm/locking-test.c        | 322 +++++++++++++++++++++++++++
 arm/spinlock-test.c       |  87 --------
 arm/tcg-test.c            | 338 ++++++++++++++++++++++++++++
 arm/tlbflush-code.c       | 209 ++++++++++++++++++
 arm/unittests.cfg         | 170 ++++++++++++++
 README.md                 |   3 +
 19 files changed, 2161 insertions(+), 92 deletions(-)
 create mode 100644 lib/prng.h
 create mode 100644 lib/prng.c
 create mode 100644 arm/tcg-test-asm.S
 create mode 100644 arm/tcg-test-asm64.S
 create mode 100644 arm/barrier-litmus-test.c
 create mode 100644 arm/locking-test.c
 delete mode 100644 arm/spinlock-test.c
 create mode 100644 arm/tcg-test.c
 create mode 100644 arm/tlbflush-code.c

Comments

Alex Bennée Dec. 10, 2021, 3:38 p.m. UTC | #1
Alex Bennée <alex.bennee@linaro.org> writes:

> Hi,
>
> Not a great deal has changed from the last posting although I have
> dropped the additional unittests.cfg in favour of setting "nodefault"
> for the tests. Otherwise the clean-ups are mainly textual (removing
> printfs, random newlines and cleaning up comments). As usual the
> details are in the commits bellow the ---.
>
> I've also tweaked .git/config so get_maintainer.pl should ensure
> direct delivery of the patches ;-)

Gentle ping...
Andrew Jones Dec. 14, 2021, 11:50 a.m. UTC | #2
On Thu, Dec 02, 2021 at 11:53:43AM +0000, Alex Bennée wrote:
> Hi,
> 
> Not a great deal has changed from the last posting although I have
> dropped the additional unittests.cfg in favour of setting "nodefault"
> for the tests. Otherwise the clean-ups are mainly textual (removing
> printfs, random newlines and cleaning up comments). As usual the
> details are in the commits bellow the ---.
> 
> I've also tweaked .git/config so get_maintainer.pl should ensure
> direct delivery of the patches ;-)
> 
> Alex Bennée (9):
>   docs: mention checkpatch in the README
>   arm/flat.lds: don't drop debug during link

>   arm/run: use separate --accel form

I queued these three to arm/queue[1].

>   Makefile: add GNU global tags support

Haven't queued this yet since I think we need .gitignore changes.

>   lib: add isaac prng library from CCAN
>   arm/tlbflush-code: TLB flush during code execution
>   arm/locking-tests: add comprehensive locking test
>   arm/barrier-litmus-tests: add simple mp and sal litmus tests
>   arm/tcg-test: some basic TCG exercising tests

These I've queued to arm/mttcg[2] with a slight change of dropping the
'mttcg' group name from any tests that can also run under kvm and
renaming mttcg to to tcg for the tests that require tcg.

I haven't pushed everything to arm/queue yet since I'm not yet sure
I like all the nodefault tests showing up in the logs, even though that
was my suggestion... I need to play with it some more.

Thanks,
drew

[1] https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/queue
[2] https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/mttcg
Andrew Jones Dec. 14, 2021, 11:54 a.m. UTC | #3
On Tue, Dec 14, 2021 at 12:50:46PM +0100, Andrew Jones wrote:
> On Thu, Dec 02, 2021 at 11:53:43AM +0000, Alex Bennée wrote:
> > Hi,
> > 
> > Not a great deal has changed from the last posting although I have
> > dropped the additional unittests.cfg in favour of setting "nodefault"
> > for the tests. Otherwise the clean-ups are mainly textual (removing
> > printfs, random newlines and cleaning up comments). As usual the
> > details are in the commits bellow the ---.
> > 
> > I've also tweaked .git/config so get_maintainer.pl should ensure
> > direct delivery of the patches ;-)
> > 
> > Alex Bennée (9):
> >   docs: mention checkpatch in the README
> >   arm/flat.lds: don't drop debug during link
> 
> >   arm/run: use separate --accel form
> 
> I queued these three to arm/queue[1].
> 
> >   Makefile: add GNU global tags support
> 
> Haven't queued this yet since I think we need .gitignore changes.
> 
> >   lib: add isaac prng library from CCAN
> >   arm/tlbflush-code: TLB flush during code execution
> >   arm/locking-tests: add comprehensive locking test
> >   arm/barrier-litmus-tests: add simple mp and sal litmus tests
> >   arm/tcg-test: some basic TCG exercising tests
> 
> These I've queued to arm/mttcg[2] with a slight change of dropping the
> 'mttcg' group name from any tests that can also run under kvm and
> renaming mttcg to to tcg for the tests that require tcg.

Hmm. I also just noticed that we should rename these tests to something
without the ::  The :: works with standalone, but it isn't all that nice
of a unix file name.

Thanks,
drew

> 
> I haven't pushed everything to arm/queue yet since I'm not yet sure
> I like all the nodefault tests showing up in the logs, even though that
> was my suggestion... I need to play with it some more.
> 
> Thanks,
> drew
> 
> [1] https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/queue
> [2] https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/arm/mttcg