mbox series

[v2,0/5] arm64: PMU updates

Message ID cover.1639490264.git.robin.murphy@arm.com (mailing list archive)
Headers show
Series arm64: PMU updates | expand

Message

Robin Murphy Dec. 14, 2021, 2:16 p.m. UTC
Hi all,

Here's v2, with the DSU binding actually finished (oh the shame...) and
the NVIDIA PMU patch pulled in to benefit from the cleanup and keep
things manageably together. The initial binding patch from v1 is no
longer included since Rob has picked it up separately.

Refactoring arm_pmu's probing to be more modular turns out to be a
substantial yak to shave, so in the end I decided it *is* worth
implementing Mark's macro suggestion now - after all, it can simply be
converted from a function template to a structure template as and when
the time comes.

Cheers,
Robin.


Robin Murphy (4):
  arm64: perf: Simplify registration boilerplate
  arm64: perf: Support new DT compatibles
  dt-bindings: perf: Convert Arm DSU to schema
  dt-bindings: perf: Add compatible for Arm DSU-110

Thierry Reding (1):
  arm64: perf: Support Denver and Carmel PMUs

 .../devicetree/bindings/arm/arm-dsu-pmu.txt   |  27 -----
 .../devicetree/bindings/perf/arm,dsu-pmu.yaml |  45 +++++++
 arch/arm64/kernel/perf_event.c                | 111 +++++++-----------
 3 files changed, 88 insertions(+), 95 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/arm-dsu-pmu.txt
 create mode 100644 Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml

Comments

Will Deacon Dec. 14, 2021, 6:33 p.m. UTC | #1
On Tue, 14 Dec 2021 14:16:12 +0000, Robin Murphy wrote:
> Here's v2, with the DSU binding actually finished (oh the shame...) and
> the NVIDIA PMU patch pulled in to benefit from the cleanup and keep
> things manageably together. The initial binding patch from v1 is no
> longer included since Rob has picked it up separately.
> 
> Refactoring arm_pmu's probing to be more modular turns out to be a
> substantial yak to shave, so in the end I decided it *is* worth
> implementing Mark's macro suggestion now - after all, it can simply be
> converted from a function template to a structure template as and when
> the time comes.
> 
> [...]

Applied first three to will (for-next/perf-cpu), thanks!

[1/5] arm64: perf: Support Denver and Carmel PMUs
      https://git.kernel.org/will/c/d4c4844a9b47
[2/5] arm64: perf: Simplify registration boilerplate
      https://git.kernel.org/will/c/6ac9f30bd43b
[3/5] arm64: perf: Support new DT compatibles
      https://git.kernel.org/will/c/893c34b60a59

Cheers,
Robin Murphy Dec. 14, 2021, 7:02 p.m. UTC | #2
On 2021-12-14 18:33, Will Deacon wrote:
> On Tue, 14 Dec 2021 14:16:12 +0000, Robin Murphy wrote:
>> Here's v2, with the DSU binding actually finished (oh the shame...) and
>> the NVIDIA PMU patch pulled in to benefit from the cleanup and keep
>> things manageably together. The initial binding patch from v1 is no
>> longer included since Rob has picked it up separately.
>>
>> Refactoring arm_pmu's probing to be more modular turns out to be a
>> substantial yak to shave, so in the end I decided it *is* worth
>> implementing Mark's macro suggestion now - after all, it can simply be
>> converted from a function template to a structure template as and when
>> the time comes.
>>
>> [...]
> 
> Applied first three to will (for-next/perf-cpu), thanks!
> 
> [1/5] arm64: perf: Support Denver and Carmel PMUs
>        https://git.kernel.org/will/c/d4c4844a9b47
> [2/5] arm64: perf: Simplify registration boilerplate
>        https://git.kernel.org/will/c/6ac9f30bd43b
> [3/5] arm64: perf: Support new DT compatibles
>        https://git.kernel.org/will/c/893c34b60a59

Thanks Will! Just to clarify, are you leaving the DSU binding patches 
for Rob to pick up, or waiting for the typo to get fixed? (and if the 
former - Rob, would you like me to resend a v3 with the typo fixed?)

Cheers,
Robin.
Will Deacon Dec. 14, 2021, 7:32 p.m. UTC | #3
On Tue, Dec 14, 2021 at 07:02:57PM +0000, Robin Murphy wrote:
> On 2021-12-14 18:33, Will Deacon wrote:
> > On Tue, 14 Dec 2021 14:16:12 +0000, Robin Murphy wrote:
> > > Here's v2, with the DSU binding actually finished (oh the shame...) and
> > > the NVIDIA PMU patch pulled in to benefit from the cleanup and keep
> > > things manageably together. The initial binding patch from v1 is no
> > > longer included since Rob has picked it up separately.
> > > 
> > > Refactoring arm_pmu's probing to be more modular turns out to be a
> > > substantial yak to shave, so in the end I decided it *is* worth
> > > implementing Mark's macro suggestion now - after all, it can simply be
> > > converted from a function template to a structure template as and when
> > > the time comes.
> > > 
> > > [...]
> > 
> > Applied first three to will (for-next/perf-cpu), thanks!
> > 
> > [1/5] arm64: perf: Support Denver and Carmel PMUs
> >        https://git.kernel.org/will/c/d4c4844a9b47
> > [2/5] arm64: perf: Simplify registration boilerplate
> >        https://git.kernel.org/will/c/6ac9f30bd43b
> > [3/5] arm64: perf: Support new DT compatibles
> >        https://git.kernel.org/will/c/893c34b60a59
> 
> Thanks Will! Just to clarify, are you leaving the DSU binding patches for
> Rob to pick up, or waiting for the typo to get fixed? (and if the former -
> Rob, would you like me to resend a v3 with the typo fixed?)

I'm about to disappear on holiday, so I figured it was best to take the
first three patches and leave the other two (as they seem less urgent and
also had comment from Suzuki). If somebody else grabs 'em when they're
ready, so be it, otherwise I'll pick them next time around.

Cheers,

Will