| Message ID | 20211213054634.30088-7-yung-chuan.liao@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio | expand |
On 13-12-21, 13:46, Bard Liao wrote: > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > cppcheck warning: > > drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a > value that is never used. [unreadVariable] > int ret = 0; > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> > Reviewed-by: Rander Wang <rander.wang@intel.com> > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- > drivers/soundwire/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index e946d1283892..45ea55a7d0c8 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev) > struct sdw_intel *sdw = cdns_to_intel(cdns); > struct sdw_bus *bus = &cdns->bus; > u32 clock_stop_quirks; > - int ret = 0; > + int ret; Ideally this should not be part of this series! If Mark wants to pick: Acked-By: Vinod Koul <vkoul@kernel.org> > > if (bus->prop.hw_disabled || !sdw->startup_done) { > dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n", > -- > 2.17.1
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index e946d1283892..45ea55a7d0c8 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev) struct sdw_intel *sdw = cdns_to_intel(cdns); struct sdw_bus *bus = &cdns->bus; u32 clock_stop_quirks; - int ret = 0; + int ret; if (bus->prop.hw_disabled || !sdw->startup_done) { dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",