mbox series

[v3,0/8] phy-rockchip-inno-usb2: support rk356x usb2phy

Message ID 20211215210252.120923-1-pgwipeout@gmail.com
Headers show
Series phy-rockchip-inno-usb2: support rk356x usb2phy | expand

Message

Peter Geis Dec. 15, 2021, 9:02 p.m. UTC
Good Afternoon,

This is my series to support the usb2 phy devices on the rk356x.
The rk356x phy has a single muxed interrupt and has moved the usb2phy
nodes out of the grf and into their own nodes.
The phy needs to tie back into the grf for register control, similar to
the rv1108.
By moving the phys into their own nodes, they now have full
#address_cells = 2 register addresses, but they still reside below the 32bit
mmio range.

This driver series only supports the host configuration for the rk356x.
I have have tested it on the following:
rk3566 - Pine64 Quartz64 Model A
rk3399 - Pine64 Rockpro64

Please provide feedback and comments as you see fit.

Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

Changelog:
v3:
- adjust usb2phy dt-bindings to filter correctly, thanks Rob and Johan
- adjust usb2phy dts names to fix alphetical ordering, thanks Michael
- squash "phy: rockchip-inno-usb2: Don't print useless error" thanks
  Ondrej

v2:
- correct the order of the usb2phy-grf dt-bindings patch, thanks Johan
- correct the conditional requirements of phy-rockchip-inno-usb2, thanks
  Johan
- drop increase generic-ohci clocks patch, thanks Heiko
- correct rk356x.dtsi ordering
- fix a dtbs-check callout

Peter Geis (8):
  dt-bindings: soc: rockchip: add rk3568-usb2phy-grf
  dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation
  phy: phy-rockchip-inno-usb2: support #address_cells = 2
  phy: phy-rockchip-inno-usb2: support standalone phy nodes
  phy: phy-rockchip-inno-usb2: support muxed interrupts
  phy: phy-rockchip-inno-usb2: add rk3568 support
  arm64: dts: rockchip: add usb2 nodes to rk3568 device tree
  arm64: dts: rockchip: add Quartz64-A usb2 support

 .../bindings/phy/phy-rockchip-inno-usb2.yaml  |  44 ++-
 .../devicetree/bindings/soc/rockchip/grf.yaml |   1 +
 .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  52 ++++
 arch/arm64/boot/dts/rockchip/rk356x.dtsi      |  98 +++++++
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 259 ++++++++++++++----
 5 files changed, 396 insertions(+), 58 deletions(-)

Comments

Vinod Koul Dec. 23, 2021, 11:25 a.m. UTC | #1
On 15-12-21, 16:02, Peter Geis wrote:
> Good Afternoon,
> 
> This is my series to support the usb2 phy devices on the rk356x.
> The rk356x phy has a single muxed interrupt and has moved the usb2phy
> nodes out of the grf and into their own nodes.
> The phy needs to tie back into the grf for register control, similar to
> the rv1108.
> By moving the phys into their own nodes, they now have full
> #address_cells = 2 register addresses, but they still reside below the 32bit
> mmio range.
> 
> This driver series only supports the host configuration for the rk356x.
> I have have tested it on the following:
> rk3566 - Pine64 Quartz64 Model A
> rk3399 - Pine64 Rockpro64
> 
> Please provide feedback and comments as you see fit.

Applied patches 2-6 to phy-next

Thanks
Heiko Stuebner Dec. 28, 2021, 12:48 a.m. UTC | #2
On Wed, 15 Dec 2021 16:02:44 -0500, Peter Geis wrote:
> Good Afternoon,
> 
> This is my series to support the usb2 phy devices on the rk356x.
> The rk356x phy has a single muxed interrupt and has moved the usb2phy
> nodes out of the grf and into their own nodes.
> The phy needs to tie back into the grf for register control, similar to
> the rv1108.
> By moving the phys into their own nodes, they now have full
> #address_cells = 2 register addresses, but they still reside below the 32bit
> mmio range.
> 
> [...]

Applied, thanks!

[1/8] dt-bindings: soc: rockchip: add rk3568-usb2phy-grf
      commit: 0c8662341dfdda1e0a59692e4d78ecb087f09da1
[7/8] arm64: dts: rockchip: add usb2 nodes to rk3568 device tree
      commit: cca4da59db28cdd284d34835be9f109f37bf0803
[8/8] arm64: dts: rockchip: add Quartz64-A usb2 support
      commit: 80d44c01e56943fcf9d0b5267ccfaa9487ac8067

Best regards,