diff mbox series

[v2] RDMA/rxe: Get rid of redundant plus

Message ID 20220104012406.27580-1-lizhijian@fujitsu.com (mailing list archive)
State Superseded
Headers show
Series [v2] RDMA/rxe: Get rid of redundant plus | expand

Commit Message

Zhijian Li (Fujitsu) Jan. 4, 2022, 1:24 a.m. UTC 
From: Li Zhijian <lizhijian@cn.fujitsu.com>

Get rid of the duplicate plus in a line to be consistent with others.

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Zhu Yanjun Jan. 4, 2022, 2:46 a.m. UTC | #1 
On Tue, Jan 4, 2022 at 9:25 AM Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
>
> Get rid of the duplicate plus in a line to be consistent with others.
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
>  drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..79122eeb4d82 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>                         [RXE_ATMETH]    = RXE_BTH_BYTES
>                                                 + RXE_RDETH_BYTES
>                                                 + RXE_DETH_BYTES,
> -                       [RXE_PAYLOAD]   = RXE_BTH_BYTES +
> +                       [RXE_PAYLOAD]   = RXE_BTH_BYTES
>                                                 + RXE_ATMETH_BYTES
> -                                               + RXE_DETH_BYTES +
> +                                               + RXE_DETH_BYTES
>                                                 + RXE_RDETH_BYTES,
>                 }
>         },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>                         [RXE_ATMETH]    = RXE_BTH_BYTES
>                                                 + RXE_RDETH_BYTES
>                                                 + RXE_DETH_BYTES,
> -                       [RXE_PAYLOAD]   = RXE_BTH_BYTES +
> +                       [RXE_PAYLOAD]   = RXE_BTH_BYTES
>                                                 + RXE_ATMETH_BYTES
> -                                               + RXE_DETH_BYTES +
> +                                               + RXE_DETH_BYTES
>                                                 + RXE_RDETH_BYTES,
>                 }
>         },
> --
> 2.33.0
>
>
>
Christoph Hellwig Jan. 4, 2022, 7:54 a.m. UTC | #2 
On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>  			[RXE_ATMETH]	= RXE_BTH_BYTES
>  						+ RXE_RDETH_BYTES
>  						+ RXE_DETH_BYTES,
> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>  						+ RXE_ATMETH_BYTES
> -						+ RXE_DETH_BYTES +
> +						+ RXE_DETH_BYTES
>  						+ RXE_RDETH_BYTES,
>  		}
>  	},
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>  			[RXE_ATMETH]	= RXE_BTH_BYTES
>  						+ RXE_RDETH_BYTES
>  						+ RXE_DETH_BYTES,
> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>  						+ RXE_ATMETH_BYTES
> -						+ RXE_DETH_BYTES +
> +						+ RXE_DETH_BYTES
>  						+ RXE_RDETH_BYTES,
>  		}
>  	},

Please fix this up to always have the + on the continuing line which
is the normal kernel style.
Zhijian Li (Fujitsu) Jan. 4, 2022, 10:38 a.m. UTC | #3 
On 04/01/2022 15:54, Christoph Hellwig wrote:
> On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
>> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
>> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
>> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
> Please fix this up to always have the + on the continuing line which
> is the normal kernel style.
I'm so glad to hear that, i will also update the existing unconventional style in this file.
diff mbox series

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 3ef5a10a6efd..79122eeb4d82 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -879,9 +879,9 @@  struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
 			[RXE_ATMETH]	= RXE_BTH_BYTES
 						+ RXE_RDETH_BYTES
 						+ RXE_DETH_BYTES,
-			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
+			[RXE_PAYLOAD]	= RXE_BTH_BYTES
 						+ RXE_ATMETH_BYTES
-						+ RXE_DETH_BYTES +
+						+ RXE_DETH_BYTES
 						+ RXE_RDETH_BYTES,
 		}
 	},
@@ -900,9 +900,9 @@  struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
 			[RXE_ATMETH]	= RXE_BTH_BYTES
 						+ RXE_RDETH_BYTES
 						+ RXE_DETH_BYTES,
-			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
+			[RXE_PAYLOAD]	= RXE_BTH_BYTES
 						+ RXE_ATMETH_BYTES
-						+ RXE_DETH_BYTES +
+						+ RXE_DETH_BYTES
 						+ RXE_RDETH_BYTES,
 		}
 	},