| Message ID | 20210121183741.45333-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [RESEND,v1] firmware: tee_bnxt: Use UUID API for exporting the UUID | expand |
On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote: > There is export_uuid() function which exports uuid_t to the u8 array. > Use it instead of open coding variant. Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? If not, why review is not done yes for more than half a year?
+ Cc: Christoph. Maybe you can apply this one, please? On Mon, Dec 13, 2021 at 10:36:55PM +0200, Andy Shevchenko wrote: > On Thu, Jan 21, 2021 at 08:37:41PM +0200, Andy Shevchenko wrote: > > There is export_uuid() function which exports uuid_t to the u8 array. > > Use it instead of open coding variant. > > Folks, is this orphaned driver? Should we update MAINTAINERS accordingly? > If not, why review is not done yes for more than half a year?
On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote:
> + Cc: Christoph. Maybe you can apply this one, please?
I've not even seen the original patch.
On Tue, Jan 04, 2022 at 10:24:06AM +0100, Christoph Hellwig wrote: > On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote: > > + Cc: Christoph. Maybe you can apply this one, please? > > I've not even seen the original patch. It's easy to retrieve with b4 tool: `b4 am -s 20210121183741.45333-1-andriy.shevchenko@linux.intel.com` But for your convenience I may resend once more with you being Cc'ed.
On Tue, Jan 04, 2022 at 03:41:51PM +0200, Andy Shevchenko wrote: > On Tue, Jan 04, 2022 at 10:24:06AM +0100, Christoph Hellwig wrote: > > On Mon, Dec 13, 2021 at 10:37:55PM +0200, Andy Shevchenko wrote: > > > + Cc: Christoph. Maybe you can apply this one, please? > > > > I've not even seen the original patch. > > It's easy to retrieve with b4 tool: > `b4 am -s 20210121183741.45333-1-andriy.shevchenko@linux.intel.com` > > But for your convenience I may resend once more with you being Cc'ed. Just sent a v2 which is basically the same :-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index ed10da5313e8..4cf0c2576037 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev) return -ENODEV; /* Open session with Bnxt load Trusted App */ - memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN); + export_uuid(sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant. This allows to hide the uuid_t internals. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)