[RESEND,v10,0/3] This patches provide ADSP IPC support for MT8195

Message

Allen-KH Cheng Dec. 10, 2021, 10:41 a.m. UTC

From: Allen-KH Cheng <[e-mail]>

Mediatek ADSP IPC is used to send notification or short message between
processors with dsp.·

It will place the message to the share buffer and will access the ADSP mailbox
registers to kick dsp.

Two mailboxes used to send notification or short message between processors with
dsp

changes since v9:
- rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops

changes since v8:
- remove struct adsp_mbox_ch_info
- add get_mtk_adsp_mbox_priv
- use mtk_adsp_mbox_priv va_mboxreg address in adsp mbox driver
- add struct mtk_adsp_mbox_cfg for DSP mbox register offset
- remove adsp mbox register offset hard code define
- remove mtk-adsp-ipc.h reference in adsp mbox driver

changes since v7:
- add mtk prefix for adsp ipc functions
- rename adsp_mbox_ch_info to mtk_adsp_mbox_ch_info
- remove incorrect reviewers in commit message

changes since v6:
- dt-bindings: change example dtsi node.
- rename config MTK_ADSP_IPC_MBOX to MTK_ADSP_MBOX
- remove unused variable
- add reviewers

changes since v5:
- remove some redundant code

changes since v4:
- use switch ... case in adsp_ipc_recv
- add error handling path for chan_name pointer
- refine some code to be concise

changes since v3:
- reorder MTK_ADSP_IPC_MBOX config
- remove some redundant code
- remove lock in mtk-adsp-mailbox

changes since v2:
- separate adsp_mailbox into two instances

changes since v1:
- fix dt_binding_check error


Allen-KH Cheng (3):
  dt-bindings: mediatek: add adsp-mbox document
  firmware: mediatek: add adsp ipc protocol interface
  mailbox: mediatek: add support for adsp mailbox controller

 .../bindings/mailbox/mtk,adsp-mbox.yaml       |  52 ++++++
 drivers/firmware/Kconfig                      |   1 +
 drivers/firmware/Makefile                     |   1 +
 drivers/firmware/mediatek/Kconfig             |   9 +
 drivers/firmware/mediatek/Makefile            |   2 +
 drivers/firmware/mediatek/mtk-adsp-ipc.c      | 135 ++++++++++++++
 drivers/mailbox/Kconfig                       |   7 +
 drivers/mailbox/Makefile                      |   2 +
 drivers/mailbox/mtk-adsp-mailbox.c            | 176 ++++++++++++++++++
 .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++
 10 files changed, 450 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml
 create mode 100644 drivers/firmware/mediatek/Kconfig
 create mode 100644 drivers/firmware/mediatek/Makefile
 create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
 create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c
 create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h

Comments

Allen-KH Cheng Jan. 4, 2022, 1:53 p.m. UTC | #1

On Fri, 2021-12-10 at 18:41 +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <[e-mail]>
> 
> Mediatek ADSP IPC is used to send notification or short message
> between
> processors with dsp.·
> 
> It will place the message to the share buffer and will access the
> ADSP mailbox
> registers to kick dsp.
> 
> Two mailboxes used to send notification or short message between
> processors with
> dsp
> 

Dear Matthias,

Do you have any comment about this patch series?

Thanks.

> changes since v9:
> - rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops
> 
> changes since v8:
> - remove struct adsp_mbox_ch_info
> - add get_mtk_adsp_mbox_priv
> - use mtk_adsp_mbox_priv va_mboxreg address in adsp mbox driver
> - add struct mtk_adsp_mbox_cfg for DSP mbox register offset
> - remove adsp mbox register offset hard code define
> - remove mtk-adsp-ipc.h reference in adsp mbox driver
> 
> changes since v7:
> - add mtk prefix for adsp ipc functions
> - rename adsp_mbox_ch_info to mtk_adsp_mbox_ch_info
> - remove incorrect reviewers in commit message
> 
> changes since v6:
> - dt-bindings: change example dtsi node.
> - rename config MTK_ADSP_IPC_MBOX to MTK_ADSP_MBOX
> - remove unused variable
> - add reviewers
> 
> changes since v5:
> - remove some redundant code
> 
> changes since v4:
> - use switch ... case in adsp_ipc_recv
> - add error handling path for chan_name pointer
> - refine some code to be concise
> 
> changes since v3:
> - reorder MTK_ADSP_IPC_MBOX config
> - remove some redundant code
> - remove lock in mtk-adsp-mailbox
> 
> changes since v2:
> - separate adsp_mailbox into two instances
> 
> changes since v1:
> - fix dt_binding_check error
> 
> 
> Allen-KH Cheng (3):
>   dt-bindings: mediatek: add adsp-mbox document
>   firmware: mediatek: add adsp ipc protocol interface
>   mailbox: mediatek: add support for adsp mailbox controller
> 
>  .../bindings/mailbox/mtk,adsp-mbox.yaml       |  52 ++++++
>  drivers/firmware/Kconfig                      |   1 +
>  drivers/firmware/Makefile                     |   1 +
>  drivers/firmware/mediatek/Kconfig             |   9 +
>  drivers/firmware/mediatek/Makefile            |   2 +
>  drivers/firmware/mediatek/mtk-adsp-ipc.c      | 135 ++++++++++++++
>  drivers/mailbox/Kconfig                       |   7 +
>  drivers/mailbox/Makefile                      |   2 +
>  drivers/mailbox/mtk-adsp-mailbox.c            | 176
> ++++++++++++++++++
>  .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++
>  10 files changed, 450 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml
>  create mode 100644 drivers/firmware/mediatek/Kconfig
>  create mode 100644 drivers/firmware/mediatek/Makefile
>  create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
>  create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c
>  create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
>