diff mbox series

[v2,3/3] staging: vc04_services: update TODO file

Message ID 3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com (mailing list archive)
State New, archived
Headers show
Series staging: vc04_services: avoid the use of typedef for function pointers | expand

Commit Message

Gaston Gonzalez Dec. 30, 2021, 11:31 a.m. UTC 
There are no struct typedef remaining inside vc04_services/. Hence, remove the
task from the TODO file.

While at it, fix the items sequential numbering.

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
 drivers/staging/vc04_services/interface/TODO | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Dan Carpenter Jan. 6, 2022, 12:51 p.m. UTC | #1 
On Thu, Dec 30, 2021 at 08:31:29AM -0300, Gaston Gonzalez wrote:
> There are no struct typedef remaining inside vc04_services/. Hence, remove the
> task from the TODO file.
> 
> While at it, fix the items sequential numbering.

The previous developers who let the numbers bitrot did the right thing.
There is a kind of ethereal beauty to misnumbered TODO lists.  #Hyperart

Or just replace the numbers with asterisks.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
index 39810ce017cd..241ca004735c 100644
--- a/drivers/staging/vc04_services/interface/TODO
+++ b/drivers/staging/vc04_services/interface/TODO
@@ -80,11 +80,7 @@  vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process.
 
 The code in vchiq_bcm2835_arm.c should fit in the generic platform file.
 
-12) Get rid of all the struct typedefs
-
-Most structs are typedefd, it's not encouraged in the kernel.
-
-13) Get rid of all non essential global structures and create a proper per
+11) Get rid of all non essential global structures and create a proper per
 device structure
 
 The first thing one generally sees in a probe function is a memory allocation
@@ -92,6 +88,6 @@  for all the device specific data. This structure is then passed all over the
 driver. This is good practice since it makes the driver work regardless of the
 number of devices probed.
 
-14) Clean up Sparse warnings from __user annotations. See
+12) Clean up Sparse warnings from __user annotations. See
 vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"
 is never disclosed to userspace.