diff mbox series

[ndctl,1/3] scripts: fix contrib/do_abidiff for updated fedpkg

Message ID 20220106050940.743232-2-vishal.l.verma@intel.com (mailing list archive)
State New, archived
Headers show
Series misc updates for release scripts | expand

Commit Message

Verma, Vishal L Jan. 6, 2022, 5:09 a.m. UTC
A recent fedpkg update wants --name instead of --module-name.

Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 contrib/do_abidiff | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Williams Jan. 6, 2022, 5:08 p.m. UTC | #1
On Wed, Jan 5, 2022 at 9:09 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> A recent fedpkg update wants --name instead of --module-name.

Ugh, how annoying.

>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  contrib/do_abidiff | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/do_abidiff b/contrib/do_abidiff
> index 0bd7a16..e8c3a65 100755
> --- a/contrib/do_abidiff
> +++ b/contrib/do_abidiff
> @@ -29,7 +29,7 @@ build_rpm()
>         version="$(./git-version)"
>         release="f$(basename $(readlink -f /etc/mock/default.cfg) | cut -d- -f2)"
>         git archive  --format=tar --prefix="ndctl-${version}/" HEAD | gzip > ndctl-${version}.tar.gz
> -       fedpkg --release $release --module-name ndctl mockbuild
> +       fedpkg --release $release --name=ndctl mockbuild

Would it be worthwhile to document the version of the fedpkg that this
script targets?

Otherwise, looks good to me.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

>         [ "$?" -eq 0 ] || err "error building $ref"
>         mkdir -p release/rel_${ref}/
>         cp results_ndctl/*/*/*.x86_64.rpm release/rel_${ref}/
> --
> 2.33.1
>
diff mbox series

Patch

diff --git a/contrib/do_abidiff b/contrib/do_abidiff
index 0bd7a16..e8c3a65 100755
--- a/contrib/do_abidiff
+++ b/contrib/do_abidiff
@@ -29,7 +29,7 @@  build_rpm()
 	version="$(./git-version)"
 	release="f$(basename $(readlink -f /etc/mock/default.cfg) | cut -d- -f2)"
 	git archive  --format=tar --prefix="ndctl-${version}/" HEAD | gzip > ndctl-${version}.tar.gz
-	fedpkg --release $release --module-name ndctl mockbuild
+	fedpkg --release $release --name=ndctl mockbuild
 	[ "$?" -eq 0 ] || err "error building $ref"
 	mkdir -p release/rel_${ref}/
 	cp results_ndctl/*/*/*.x86_64.rpm release/rel_${ref}/