| Message ID | 20220106111614.218823-1-alice.ferrazzi@miraclelinux.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add cip-core-image-kernelci building and uploading system | expand |
On 06.01.22 12:16, Alice Ferrazzi wrote: > This patch series add a new image with settings for > KernelCI. > > This new image is called cip-core-image-kernelci and is > based on isar-cip-core general image with some changes > needed for make it work with KernelCI and taken from > KernelCI image base settings. > The cip-core-image-kernelci images are built by GitlabCI > and uploaded to KernelCI production fileserver. > https://storage.kernelci.org/images/rootfs/cip/ > > These patches are already integrated in the > isar-cip-core:alicef/kernelci_master_refactor repository branch > and are generating the images that are currently > used by KernelCI. > > cip-core-image-kernelci as been tested and are > already used in KernelCI production with good results. > https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ > > Alice Ferrazzi (4): > Add cip-core-image-kernelci > Add dmesg filter needed for lava test result > Add script deploy-kernelci.py for upload the cip-core-image-kernelci > enable cip-core-image-kernelci > > .gitlab-ci.yml | 40 +++++++++++++- > kas/opt/kernelci.yml | 16 ++++++ > .../images/cip-core-image-kernelci.bb | 16 ++++++ > .../files/99-silent-printk.conf | 1 + > .../kernelci-customizations/files/dmesg.sh | 23 ++++++++ > .../kernelci-customizations/files/ethernet | 23 ++++++++ > .../kernelci-customizations/files/postinst | 34 ++++++++++++ > .../kernelci-customizations.bb | 35 ++++++++++++ > scripts/deploy-kernelci.py | 55 +++++++++++++++++++ > 9 files changed, 242 insertions(+), 1 deletion(-) > create mode 100644 kas/opt/kernelci.yml > create mode 100644 recipes-core/images/cip-core-image-kernelci.bb > create mode 100644 recipes-core/kernelci-customizations/files/99-silent-printk.conf > create mode 100644 recipes-core/kernelci-customizations/files/dmesg.sh > create mode 100644 recipes-core/kernelci-customizations/files/ethernet > create mode 100644 recipes-core/kernelci-customizations/files/postinst > create mode 100644 recipes-core/kernelci-customizations/kernelci-customizations.bb > create mode 100755 scripts/deploy-kernelci.py > This is v2 of https://lists.cip-project.org/g/cip-dev/message/7264, right? Please flag that in the future. What is the delta? Jan
On 06.01.22 12:16, Alice Ferrazzi wrote: > This patch series add a new image with settings for > KernelCI. > > This new image is called cip-core-image-kernelci and is > based on isar-cip-core general image with some changes > needed for make it work with KernelCI and taken from > KernelCI image base settings. > The cip-core-image-kernelci images are built by GitlabCI > and uploaded to KernelCI production fileserver. > https://storage.kernelci.org/images/rootfs/cip/ > > These patches are already integrated in the > isar-cip-core:alicef/kernelci_master_refactor repository branch > and are generating the images that are currently > used by KernelCI. > > cip-core-image-kernelci as been tested and are > already used in KernelCI production with good results. > https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ > Thanks a lot for enabling this! One meta-question: How does this image relate to what happens to a standard image when adding kas/opt/test.yml? Does kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former actually include the latter? These things you may ask yourself when try to add the image also to our Kconfig menu ("kas-container menu"). That would be nice to have for a v3 as well, but more important is sorting out the option relationships. Thanks, Jan
On Thu, Jan 6, 2022 at 11:18 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 06.01.22 12:16, Alice Ferrazzi wrote: > > This patch series add a new image with settings for > > KernelCI. > > > > This new image is called cip-core-image-kernelci and is > > based on isar-cip-core general image with some changes > > needed for make it work with KernelCI and taken from > > KernelCI image base settings. > > The cip-core-image-kernelci images are built by GitlabCI > > and uploaded to KernelCI production fileserver. > > https://storage.kernelci.org/images/rootfs/cip/ > > > > These patches are already integrated in the > > isar-cip-core:alicef/kernelci_master_refactor repository branch > > and are generating the images that are currently > > used by KernelCI. > > > > cip-core-image-kernelci as been tested and are > > already used in KernelCI production with good results. > > https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ > > > > Thanks a lot for enabling this! > > One meta-question: How does this image relate to what happens to a > standard image when adding kas/opt/test.yml? Does > kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former > actually include the latter? Currently it doesn't make too much sense to add such testing packages. CIP kernel image testing is done using ad-hoc images with a KernelCI built version of the testing packages for having a common base and better compare results with other kernels. cip-core-image-kernelci is currently tested as booting image with dmesg checks for each kernel (but still using specific KernelCI configurations and scripts). We are currently trying to implement the iec-security test as user space test that will use cip-core-image-kernelci, I sent a pull request for implementing the user space test iec-security but is still in progress. Because KernelCI testings and test environments differs from CIP gitlab pipeline test environment, we have to use a different file and merging both would currently make such different environments unstable. I hope that this answer your question. > These things you may ask yourself when try to add the image also to our > Kconfig menu ("kas-container menu"). That would be nice to have for a v3 > as well, but more important is sorting out the option relationships. cip-core-image-kernelci are build using gitlab pipeline and there is currently no benefit to have such images manual build. Thanks, Alice
On 07.01.22 10:57, Alice Ferrazzi wrote: > On Thu, Jan 6, 2022 at 11:18 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: >> >> On 06.01.22 12:16, Alice Ferrazzi wrote: >>> This patch series add a new image with settings for >>> KernelCI. >>> >>> This new image is called cip-core-image-kernelci and is >>> based on isar-cip-core general image with some changes >>> needed for make it work with KernelCI and taken from >>> KernelCI image base settings. >>> The cip-core-image-kernelci images are built by GitlabCI >>> and uploaded to KernelCI production fileserver. >>> https://storage.kernelci.org/images/rootfs/cip/ >>> >>> These patches are already integrated in the >>> isar-cip-core:alicef/kernelci_master_refactor repository branch >>> and are generating the images that are currently >>> used by KernelCI. >>> >>> cip-core-image-kernelci as been tested and are >>> already used in KernelCI production with good results. >>> https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ >>> >> >> Thanks a lot for enabling this! >> >> One meta-question: How does this image relate to what happens to a >> standard image when adding kas/opt/test.yml? Does >> kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former >> actually include the latter? > > Currently it doesn't make too much sense to add such testing packages. > CIP kernel image testing is done using ad-hoc images with a KernelCI > built version of the > testing packages for having a common base and better compare results > with other kernels. > cip-core-image-kernelci is currently tested as booting image with > dmesg checks for each kernel (but still using specific KernelCI > configurations and scripts). > We are currently trying to implement the iec-security test as user > space test that will use cip-core-image-kernelci, > I sent a pull request for implementing the user space test > iec-security but is still in progress. > Because KernelCI testings and test environments differs from CIP > gitlab pipeline test environment, > we have to use a different file and merging both would currently make > such different environments unstable. > > I hope that this answer your question. Ok, we just need to keep an eye on target configs and options that deal with "testing" so that things are consistent and intuitive. > >> These things you may ask yourself when try to add the image also to our >> Kconfig menu ("kas-container menu"). That would be nice to have for a v3 >> as well, but more important is sorting out the option relationships. > > cip-core-image-kernelci are build using gitlab pipeline and there is > currently no benefit to have such > images manual build. > So, the case that a test fails on kernel CI and someone want to reproduce the image that triggered this does not exist? One would rather build a regular image for the target then? Jan
On Fri, Jan 7, 2022 at 7:11 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 07.01.22 10:57, Alice Ferrazzi wrote: > > On Thu, Jan 6, 2022 at 11:18 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > >> > >> On 06.01.22 12:16, Alice Ferrazzi wrote: > >>> This patch series add a new image with settings for > >>> KernelCI. > >>> > >>> This new image is called cip-core-image-kernelci and is > >>> based on isar-cip-core general image with some changes > >>> needed for make it work with KernelCI and taken from > >>> KernelCI image base settings. > >>> The cip-core-image-kernelci images are built by GitlabCI > >>> and uploaded to KernelCI production fileserver. > >>> https://storage.kernelci.org/images/rootfs/cip/ > >>> > >>> These patches are already integrated in the > >>> isar-cip-core:alicef/kernelci_master_refactor repository branch > >>> and are generating the images that are currently > >>> used by KernelCI. > >>> > >>> cip-core-image-kernelci as been tested and are > >>> already used in KernelCI production with good results. > >>> https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ > >>> > >> > >> Thanks a lot for enabling this! > >> > >> One meta-question: How does this image relate to what happens to a > >> standard image when adding kas/opt/test.yml? Does > >> kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former > >> actually include the latter? > > > > Currently it doesn't make too much sense to add such testing packages. > > CIP kernel image testing is done using ad-hoc images with a KernelCI > > built version of the > > testing packages for having a common base and better compare results > > with other kernels. > > cip-core-image-kernelci is currently tested as booting image with > > dmesg checks for each kernel (but still using specific KernelCI > > configurations and scripts). > > We are currently trying to implement the iec-security test as user > > space test that will use cip-core-image-kernelci, > > I sent a pull request for implementing the user space test > > iec-security but is still in progress. > > Because KernelCI testings and test environments differs from CIP > > gitlab pipeline test environment, > > we have to use a different file and merging both would currently make > > such different environments unstable. > > > > I hope that this answer your question. > > Ok, we just need to keep an eye on target configs and options that deal > with "testing" so that things are consistent and intuitive. > > > > >> These things you may ask yourself when try to add the image also to our > >> Kconfig menu ("kas-container menu"). That would be nice to have for a v3 > >> as well, but more important is sorting out the option relationships. > > > > cip-core-image-kernelci are build using gitlab pipeline and there is > > currently no benefit to have such > > images manual build. > > > > So, the case that a test fails on kernel CI and someone want to > reproduce the image that triggered this does not exist? One would rather > build a regular image for the target then? > Why not just using the pre made image from https://storage.kernelci.org/images/rootfs/cip/ for reproducing errors ? Thanks, Alicef
On 07.01.22 11:19, Alice Ferrazzi wrote: > On Fri, Jan 7, 2022 at 7:11 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: >> >> On 07.01.22 10:57, Alice Ferrazzi wrote: >>> On Thu, Jan 6, 2022 at 11:18 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> >>>> On 06.01.22 12:16, Alice Ferrazzi wrote: >>>>> This patch series add a new image with settings for >>>>> KernelCI. >>>>> >>>>> This new image is called cip-core-image-kernelci and is >>>>> based on isar-cip-core general image with some changes >>>>> needed for make it work with KernelCI and taken from >>>>> KernelCI image base settings. >>>>> The cip-core-image-kernelci images are built by GitlabCI >>>>> and uploaded to KernelCI production fileserver. >>>>> https://storage.kernelci.org/images/rootfs/cip/ >>>>> >>>>> These patches are already integrated in the >>>>> isar-cip-core:alicef/kernelci_master_refactor repository branch >>>>> and are generating the images that are currently >>>>> used by KernelCI. >>>>> >>>>> cip-core-image-kernelci as been tested and are >>>>> already used in KernelCI production with good results. >>>>> https://linux.kernelci.org/test/job/stable-rc/branch/queue%2F5.14/kernel/v5.14.17-9-g9f7eecaa70b3/plan/baseline-cip-nfs/ >>>>> >>>> >>>> Thanks a lot for enabling this! >>>> >>>> One meta-question: How does this image relate to what happens to a >>>> standard image when adding kas/opt/test.yml? Does >>>> kas/opt/kernelci.yml:kas/opt/test.yml make sense? Or should the former >>>> actually include the latter? >>> >>> Currently it doesn't make too much sense to add such testing packages. >>> CIP kernel image testing is done using ad-hoc images with a KernelCI >>> built version of the >>> testing packages for having a common base and better compare results >>> with other kernels. >>> cip-core-image-kernelci is currently tested as booting image with >>> dmesg checks for each kernel (but still using specific KernelCI >>> configurations and scripts). >>> We are currently trying to implement the iec-security test as user >>> space test that will use cip-core-image-kernelci, >>> I sent a pull request for implementing the user space test >>> iec-security but is still in progress. >>> Because KernelCI testings and test environments differs from CIP >>> gitlab pipeline test environment, >>> we have to use a different file and merging both would currently make >>> such different environments unstable. >>> >>> I hope that this answer your question. >> >> Ok, we just need to keep an eye on target configs and options that deal >> with "testing" so that things are consistent and intuitive. >> >>> >>>> These things you may ask yourself when try to add the image also to our >>>> Kconfig menu ("kas-container menu"). That would be nice to have for a v3 >>>> as well, but more important is sorting out the option relationships. >>> >>> cip-core-image-kernelci are build using gitlab pipeline and there is >>> currently no benefit to have such >>> images manual build. >>> >> >> So, the case that a test fails on kernel CI and someone want to >> reproduce the image that triggered this does not exist? One would rather >> build a regular image for the target then? >> > > Why not just using the pre made image from > https://storage.kernelci.org/images/rootfs/cip/ > for reproducing errors ? Fine, as long as you do not need to adjust things in it afterwards. Granted, such cases will be less common. Jan