mbox series

[PATCHv3,for-next,0/5] RTRS renaming

Message ID 20220105180708.7774-1-jinpu.wang@ionos.com (mailing list archive)
Headers show
Series RTRS renaming | expand

Message

Jinpu Wang Jan. 5, 2022, 6:07 p.m. UTC
Hi Jason, hi Leon,

This patchset from Vaishali, renames a few internal structures to make
the code easier to understand.

rtrs_sess is in fact a path. rtrs_clt/_srv is in fact a session.
This is a mess and makes it difficult to get into the code.

The patchset is based on rdma/for-next:
c8f476da84ad ("Merge branch 'mlx5-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux")

v3: rename a few more variables in log/comments. (Thanks Guoqing)
more detailed changelog in patch 2/3/5

v2: merge first 3 patches to one to be bisectable. (Thanks Guoqing)
https://lore.kernel.org/linux-rdma/20220103133339.9483-1-jinpu.wang@ionos.com/T/#t

v1: https://lore.kernel.org/linux-rdma/aac5544b-279d-35f5-6f19-eb0301294122@linux.dev/T/#md5be427877cbfcb1741cccea4d081df09ae18561


Thanks!

Vaishali Thakkar (5):
  RDMA/rtrs: Rename rtrs_sess to rtrs_path
  RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path
  RDMA/rtrs-clt: Rename rtrs_clt_sess to rtrs_clt_path
  RDMA/rtrs-srv: Rename rtrs_srv to rtrs_srv_sess
  RDMA/rtrs-clt: Rename rtrs_clt to rtrs_clt_sess

 drivers/block/rnbd/rnbd-clt.c                |    4 +-
 drivers/block/rnbd/rnbd-clt.h                |    2 +-
 drivers/block/rnbd/rnbd-srv.c                |   16 +-
 drivers/block/rnbd/rnbd-srv.h                |    2 +-
 drivers/infiniband/ulp/rtrs/rtrs-clt-stats.c |    8 +-
 drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c |  145 +--
 drivers/infiniband/ulp/rtrs/rtrs-clt.c       | 1087 +++++++++---------
 drivers/infiniband/ulp/rtrs/rtrs-clt.h       |   41 +-
 drivers/infiniband/ulp/rtrs/rtrs-pri.h       |   18 +-
 drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c |  121 +-
 drivers/infiniband/ulp/rtrs/rtrs-srv.c       |  684 +++++------
 drivers/infiniband/ulp/rtrs/rtrs-srv.h       |   16 +-
 drivers/infiniband/ulp/rtrs/rtrs.c           |   98 +-
 drivers/infiniband/ulp/rtrs/rtrs.h           |   34 +-
 14 files changed, 1156 insertions(+), 1120 deletions(-)

Comments

Jason Gunthorpe Jan. 7, 2022, 2:48 p.m. UTC | #1
On Wed, Jan 05, 2022 at 07:07:03PM +0100, Jack Wang wrote:
> Hi Jason, hi Leon,
> 
> This patchset from Vaishali, renames a few internal structures to make
> the code easier to understand.
> 
> rtrs_sess is in fact a path. rtrs_clt/_srv is in fact a session.
> This is a mess and makes it difficult to get into the code.
> 
> The patchset is based on rdma/for-next:
> c8f476da84ad ("Merge branch 'mlx5-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux")
> 
> v3: rename a few more variables in log/comments. (Thanks Guoqing)
> more detailed changelog in patch 2/3/5
> 
> v2: merge first 3 patches to one to be bisectable. (Thanks Guoqing)
> https://lore.kernel.org/linux-rdma/20220103133339.9483-1-jinpu.wang@ionos.com/T/#t
> 
> v1: https://lore.kernel.org/linux-rdma/aac5544b-279d-35f5-6f19-eb0301294122@linux.dev/T/#md5be427877cbfcb1741cccea4d081df09ae18561
> 
> 
> Thanks!
> 
> Vaishali Thakkar (5):
>   RDMA/rtrs: Rename rtrs_sess to rtrs_path
>   RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path
>   RDMA/rtrs-clt: Rename rtrs_clt_sess to rtrs_clt_path
>   RDMA/rtrs-srv: Rename rtrs_srv to rtrs_srv_sess
>   RDMA/rtrs-clt: Rename rtrs_clt to rtrs_clt_sess

Applied to for-next, thanks

Jason