diff mbox series

[v2,03/11] dt-bindings: media: i2c: max9286: Add property to select bus width

Message ID 20220101182806.19311-4-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State New
Delegated to: Kieran Bingham
Headers show
Series media: i2c: max9286: Small new features | expand

Commit Message

Laurent Pinchart Jan. 1, 2022, 6:27 p.m. UTC
The GMSL serial data bus width is normally selected by the BWS pin, but
it can also be configured by software. Add a DT property that allows
overriding the value of the BWS-selected bus width to support systems
whose BWS pin doesn't result in the correct value.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 .../devicetree/bindings/media/i2c/maxim,max9286.yaml       | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jacopo Mondi Jan. 9, 2022, 11:47 a.m. UTC | #1
Hi Laurent,

On Sat, Jan 01, 2022 at 08:27:58PM +0200, Laurent Pinchart wrote:
> The GMSL serial data bus width is normally selected by the BWS pin, but
> it can also be configured by software. Add a DT property that allows
> overriding the value of the BWS-selected bus width to support systems
> whose BWS pin doesn't result in the correct value.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks
  j

> ---
>  .../devicetree/bindings/media/i2c/maxim,max9286.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index 5d3e99027a79..123e98cdb7b6 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -50,6 +50,13 @@ properties:
>    '#gpio-cells':
>      const: 2
>
> +  maxim,bus-width:
> +    enum: [ 24, 27, 32 ]
> +    description: |
> +      The GMSL serial data bus width. This setting is normally controlled by
> +      the BWS pin, but may be overridden with this property. The value must
> +      match the configuration of the remote serializers.
> +
>    maxim,i2c-clock-frequency:
>      enum: [ 8470, 28300, 84700, 105000, 173000, 339000, 533000, 837000 ]
>      default: 105000
> --
> Regards,
>
> Laurent Pinchart
>
Rob Herring (Arm) Jan. 10, 2022, 8:53 p.m. UTC | #2
On Sat, Jan 01, 2022 at 08:27:58PM +0200, Laurent Pinchart wrote:
> The GMSL serial data bus width is normally selected by the BWS pin, but
> it can also be configured by software. Add a DT property that allows
> overriding the value of the BWS-selected bus width to support systems
> whose BWS pin doesn't result in the correct value.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  .../devicetree/bindings/media/i2c/maxim,max9286.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index 5d3e99027a79..123e98cdb7b6 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -50,6 +50,13 @@ properties:
>    '#gpio-cells':
>      const: 2
>  
> +  maxim,bus-width:

Needs a $ref to a type.

> +    enum: [ 24, 27, 32 ]
> +    description: |
> +      The GMSL serial data bus width. This setting is normally controlled by
> +      the BWS pin, but may be overridden with this property. The value must
> +      match the configuration of the remote serializers.
> +
>    maxim,i2c-clock-frequency:
>      enum: [ 8470, 28300, 84700, 105000, 173000, 339000, 533000, 837000 ]
>      default: 105000
> -- 
> Regards,
> 
> Laurent Pinchart
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
index 5d3e99027a79..123e98cdb7b6 100644
--- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
@@ -50,6 +50,13 @@  properties:
   '#gpio-cells':
     const: 2
 
+  maxim,bus-width:
+    enum: [ 24, 27, 32 ]
+    description: |
+      The GMSL serial data bus width. This setting is normally controlled by
+      the BWS pin, but may be overridden with this property. The value must
+      match the configuration of the remote serializers.
+
   maxim,i2c-clock-frequency:
     enum: [ 8470, 28300, 84700, 105000, 173000, 339000, 533000, 837000 ]
     default: 105000