diff mbox series

counter: 104-quad-8: Add COMPILE_TEST depends

Message ID 20220105094137.259111-1-vilhelm.gray@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series counter: 104-quad-8: Add COMPILE_TEST depends | expand

Commit Message

William Breathitt Gray Jan. 5, 2022, 9:41 a.m. UTC 
104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
adds support for COMPILE_TEST which is useful for compile testing code
changes to the driver and Counter subsystem.

Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/counter/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 088879292a0a3672a6acc9215174fbc355ed3daa

Comments

Uwe Kleine-König Jan. 9, 2022, 9:22 p.m. UTC | #1 
On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> adds support for COMPILE_TEST which is useful for compile testing code
> changes to the driver and Counter subsystem.
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
>  drivers/counter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 3dcdb681c4e4..5edd155f1911 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -14,7 +14,7 @@ if COUNTER
>  
>  config 104_QUAD_8
>  	tristate "ACCES 104-QUAD-8 driver"
> -	depends on PC104 && X86
> +	depends on (PC104 && X86) || COMPILE_TEST

The driver uses inb and friends. Without looking I wonder if there is
something like HAVE_IO or similar this needs to depend on for that?

Best regards
Uwe
William Breathitt Gray Jan. 10, 2022, 5:36 a.m. UTC | #2 
On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-König wrote:
> On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> > 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> > adds support for COMPILE_TEST which is useful for compile testing code
> > changes to the driver and Counter subsystem.
> > 
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > ---
> >  drivers/counter/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 3dcdb681c4e4..5edd155f1911 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -14,7 +14,7 @@ if COUNTER
> >  
> >  config 104_QUAD_8
> >  	tristate "ACCES 104-QUAD-8 driver"
> > -	depends on PC104 && X86
> > +	depends on (PC104 && X86) || COMPILE_TEST
> 
> The driver uses inb and friends. Without looking I wonder if there is
> something like HAVE_IO or similar this needs to depend on for that?
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |

If I'm not mistaken, on unsupported architectures include/linux/io.h
will pull in include/asm-generic/io.h which has default implementations
for inb and friends if they are not otherwise defined. It doesn't look
like these default implementations are guarded by a Kconfig setting so
we should be fine in this case.

William Breathitt Gray
Uwe Kleine-König Jan. 10, 2022, 8:36 a.m. UTC | #3 
On Mon, Jan 10, 2022 at 02:36:54PM +0900, William Breathitt Gray wrote:
> On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-König wrote:
> > On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> > > 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> > > adds support for COMPILE_TEST which is useful for compile testing code
> > > changes to the driver and Counter subsystem.
> > > 
> > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > > ---
> > >  drivers/counter/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > > index 3dcdb681c4e4..5edd155f1911 100644
> > > --- a/drivers/counter/Kconfig
> > > +++ b/drivers/counter/Kconfig
> > > @@ -14,7 +14,7 @@ if COUNTER
> > >  
> > >  config 104_QUAD_8
> > >  	tristate "ACCES 104-QUAD-8 driver"
> > > -	depends on PC104 && X86
> > > +	depends on (PC104 && X86) || COMPILE_TEST
> > 
> > The driver uses inb and friends. Without looking I wonder if there is
> > something like HAVE_IO or similar this needs to depend on for that?
> > 
> > Best regards
> > Uwe
> > 
> > -- 
> > Pengutronix e.K.                           | Uwe Kleine-König            |
> > Industrial Linux Solutions                 | https://www.pengutronix.de/ |
> 
> If I'm not mistaken, on unsupported architectures include/linux/io.h
> will pull in include/asm-generic/io.h which has default implementations
> for inb and friends if they are not otherwise defined. It doesn't look
> like these default implementations are guarded by a Kconfig setting so
> we should be fine in this case.

Looks right, thanks for checking

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 3dcdb681c4e4..5edd155f1911 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -14,7 +14,7 @@  if COUNTER
 
 config 104_QUAD_8
 	tristate "ACCES 104-QUAD-8 driver"
-	depends on PC104 && X86
+	depends on (PC104 && X86) || COMPILE_TEST
 	select ISA_BUS_API
 	help
 	  Say yes here to build support for the ACCES 104-QUAD-8 quadrature