| Message ID | 20220110073733.3221379-1-yanjun.zhu@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [1/1] RDMA/irdma: Remove the redundant return | expand |
On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The type of the function i40iw_remove is void. So remove > the unnecessary return. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > --- > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c > index d219f64b2c3d..43e962b97d6a 100644 > --- a/drivers/infiniband/hw/irdma/i40iw_if.c > +++ b/drivers/infiniband/hw/irdma/i40iw_if.c > @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev) > aux_dev); > struct i40e_info *cdev_info = i40e_adev->ldev; > > - return i40e_client_device_unregister(cdev_info); > + i40e_client_device_unregister(cdev_info); I'm surprised that compiler didn't warn about extra parameter to return. Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Sun, Jan 09, 2022 at 08:44:55PM +0200, Leon Romanovsky wrote: > On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote: > > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > > > The type of the function i40iw_remove is void. So remove > > the unnecessary return. > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c > > index d219f64b2c3d..43e962b97d6a 100644 > > +++ b/drivers/infiniband/hw/irdma/i40iw_if.c > > @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev) > > aux_dev); > > struct i40e_info *cdev_info = i40e_adev->ldev; > > > > - return i40e_client_device_unregister(cdev_info); > > + i40e_client_device_unregister(cdev_info); > > I'm surprised that compiler didn't warn about extra parameter to return. It is odd, but valid, C to return void like this.. Jason
On Mon, Jan 10, 2022 at 08:54:07AM -0400, Jason Gunthorpe wrote: > On Sun, Jan 09, 2022 at 08:44:55PM +0200, Leon Romanovsky wrote: > > On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote: > > > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > > > > > The type of the function i40iw_remove is void. So remove > > > the unnecessary return. > > > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > > > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c > > > index d219f64b2c3d..43e962b97d6a 100644 > > > +++ b/drivers/infiniband/hw/irdma/i40iw_if.c > > > @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev) > > > aux_dev); > > > struct i40e_info *cdev_info = i40e_adev->ldev; > > > > > > - return i40e_client_device_unregister(cdev_info); > > > + i40e_client_device_unregister(cdev_info); > > > > I'm surprised that compiler didn't warn about extra parameter to return. > > It is odd, but valid, C to return void like this.. Any idea where such C expression can be useful? Thanks > > Jason
> Subject: [PATCH 1/1] RDMA/irdma: Remove the redundant return > > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The type of the function i40iw_remove is void. So remove the unnecessary return. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > --- > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
On Mon, Jan 10, 2022 at 02:37:33AM -0500, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The type of the function i40iw_remove is void. So remove > the unnecessary return. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> > --- > drivers/infiniband/hw/irdma/i40iw_if.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c index d219f64b2c3d..43e962b97d6a 100644 --- a/drivers/infiniband/hw/irdma/i40iw_if.c +++ b/drivers/infiniband/hw/irdma/i40iw_if.c @@ -198,7 +198,7 @@ static void i40iw_remove(struct auxiliary_device *aux_dev) aux_dev); struct i40e_info *cdev_info = i40e_adev->ldev; - return i40e_client_device_unregister(cdev_info); + i40e_client_device_unregister(cdev_info); } static const struct auxiliary_device_id i40iw_auxiliary_id_table[] = {