| Message ID | 20220109231716.59012-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | edcb501e543cecaff5e3d079c798911e680fea65 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: at803x: make array offsets static | expand |
On Sun, Jan 09, 2022 at 11:17:16PM +0000, Colin Ian King wrote: > Don't populate the read-only const array offsets on the stack > but instead make it static. Also makes the object code a little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sun, 9 Jan 2022 23:17:16 +0000 you wrote: > Don't populate the read-only const array offsets on the stack > but instead make it static. Also makes the object code a little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/phy/at803x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - net: phy: at803x: make array offsets static https://git.kernel.org/netdev/net/c/edcb501e543c You are awesome, thank you!
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index dae95d9a07e8..5b6c0d120e09 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -421,7 +421,7 @@ static int at803x_set_wol(struct phy_device *phydev, const u8 *mac; int ret, irq_enabled; unsigned int i; - const unsigned int offsets[] = { + static const unsigned int offsets[] = { AT803X_LOC_MAC_ADDR_32_47_OFFSET, AT803X_LOC_MAC_ADDR_16_31_OFFSET, AT803X_LOC_MAC_ADDR_0_15_OFFSET,
Don't populate the read-only const array offsets on the stack but instead make it static. Also makes the object code a little smaller. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/phy/at803x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)