diff mbox series

[1/4] t5540: require REFFILES

Message ID e0d7dbf8b552381a9b7854f2bb9eff41508aac04.1640170784.git.gitgitgadget@gmail.com (mailing list archive)
State Accepted
Commit 8c21d820e9ddaf7ddcb0c882f27bec017e28984f
Headers show
Series Reftable test fixes 20211221 | expand

Commit Message

Han-Wen Nienhuys Dec. 22, 2021, 10:59 a.m. UTC 
From: Han-Wen Nienhuys <hanwen@google.com>

The dumb HTTP protocol exposes ref storage details as part of the protocol,
so it only works with the FILES refstorage backend

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 t/t5540-http-push-webdav.sh | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Bagas Sanjaya Dec. 24, 2021, 5:14 a.m. UTC | #1 
On 22/12/21 17.59, Han-Wen Nienhuys via GitGitGadget wrote:
> +if test_have_prereq !REFFILES
> +then
> +	skip_all='skipping test; dumb HTTP protocol not supported with reftable.'
> +	test_done
> +fi
> +

Did you mean reftable doesn't support dumb HTTP protocol or vice versa?
Han-Wen Nienhuys Jan. 10, 2022, 6:29 p.m. UTC | #2 
On Fri, Dec 24, 2021 at 6:14 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 22/12/21 17.59, Han-Wen Nienhuys via GitGitGadget wrote:
> > +if test_have_prereq !REFFILES
> > +then
> > +     skip_all='skipping test; dumb HTTP protocol not supported with reftable.'
> > +     test_done
> > +fi
> > +
>
> Did you mean reftable doesn't support dumb HTTP protocol or vice versa?

AFAIK, the 'dumb protocol' isn't really a protocol, but is simply
exposing the file system over HTTP.

I suppose we could expose the reftable files over HTTP, but that means
we have to rewrite the client to understand reftable files if they are
served. However, I get the impression that nobody really uses the dumb
protocol anymore, so is it worth trying to make this work for
reftable?
diff mbox series

Patch

diff --git a/t/t5540-http-push-webdav.sh b/t/t5540-http-push-webdav.sh
index 8b68bb38a44..b0dbacf0b9b 100755
--- a/t/t5540-http-push-webdav.sh
+++ b/t/t5540-http-push-webdav.sh
@@ -18,6 +18,12 @@  then
 	test_done
 fi
 
+if test_have_prereq !REFFILES
+then
+	skip_all='skipping test; dumb HTTP protocol not supported with reftable.'
+	test_done
+fi
+
 LIB_HTTPD_DAV=t
 . "$TEST_DIRECTORY"/lib-httpd.sh
 ROOT_PATH="$PWD"