| Message ID | 20220110104214.25321-2-yu.tu@amlogic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | The UART driver compatible with | expand |
On Mon, Jan 10, 2022 at 4:42 AM Yu Tu <yu.tu@amlogic.com> wrote: > > Deprecated, don't use anymore because legacy amlogic,meson-gx-uart > compatible. Don't differentiate between GXBB, GXL and G12A which > have different revisions of the UART IP. So it's split into > GXBB,GXL and G12A. You are breaking compatibility. If your dts is updated to use the new compatible, then a kernel without the change will not work anymore. It worked before without understanding the changes you are making. It should continue to. A compatible value like this would accomplish what you want: "amlogic,meson-gxbb-uart", "amlogic,meson-gx-uart", "amlogic,meson-ao-uart" A new kernel will match on "amlogic,meson-gxbb-uart" or "amlogic,meson-gx-uart" depending if the dtb is updated or not. An old kernel will continue to match on "amlogic,meson-gx-uart". If you are going to go breaking things, the power domain distinction in the compatible is odd... Rob
Hi Rob, Thank you very much for your reply. On 2022/1/11 0:18, Rob Herring wrote: > [ EXTERNAL EMAIL ] > > On Mon, Jan 10, 2022 at 4:42 AM Yu Tu <yu.tu@amlogic.com> wrote: >> >> Deprecated, don't use anymore because legacy amlogic,meson-gx-uart >> compatible. Don't differentiate between GXBB, GXL and G12A which >> have different revisions of the UART IP. So it's split into >> GXBB,GXL and G12A. > > You are breaking compatibility. If your dts is updated to use the new > compatible, then a kernel without the change will not work anymore. It > worked before without understanding the changes you are making. It > should continue to. A compatible value like this would accomplish what > you want: > > "amlogic,meson-gxbb-uart", "amlogic,meson-gx-uart", "amlogic,meson-ao-uart" > > A new kernel will match on "amlogic,meson-gxbb-uart" or > "amlogic,meson-gx-uart" depending if the dtb is updated or not. An old > kernel will continue to match on "amlogic,meson-gx-uart". > > If you are going to go breaking things, the power domain distinction > in the compatible is odd... > I will not blindly delete this "amlogic, meson-gx-uart" compatible as you suggest, just make a comment until all DTS changes are finished. > > Rob >
diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml index 72e8868db3e0..ad9f1f4537a0 100644 --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml @@ -28,7 +28,10 @@ properties: - amlogic,meson6-uart - amlogic,meson8-uart - amlogic,meson8b-uart - - amlogic,meson-gx-uart + - amlogic,meson-gx-uart # deprecated, use revision specific property below + - amlogic,meson-gxbb-uart + - amlogic,meson-gxl-uart + - amlogic,meson-g12a-uart - amlogic,meson-s4-uart - const: amlogic,meson-ao-uart - description: Everything-Else power domain UART controller @@ -36,7 +39,10 @@ properties: - amlogic,meson6-uart - amlogic,meson8-uart - amlogic,meson8b-uart - - amlogic,meson-gx-uart + - amlogic,meson-gx-uart # deprecated, use revision specific property below + - amlogic,meson-gxbb-uart + - amlogic,meson-gxl-uart + - amlogic,meson-g12a-uart - amlogic,meson-s4-uart reg:
Deprecated, don't use anymore because legacy amlogic,meson-gx-uart compatible. Don't differentiate between GXBB, GXL and G12A which have different revisions of the UART IP. So it's split into GXBB,GXL and G12A. Signed-off-by: Yu Tu <yu.tu@amlogic.com> --- .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)