| Message ID | 20220111010302.8864-2-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node | expand |
On Tue, Jan 11, 2022 at 9:03 AM Wei Yang <richard.weiyang@gmail.com> wrote: > > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On Tue 11-01-22 01:03:00, Wei Yang wrote: > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 11715f7323c0..a504616f904a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > } > > lruvec_init(&pn->lruvec); > - pn->usage_in_excess = 0; > - pn->on_tree = false; > pn->memcg = memcg; > > memcg->nodeinfo[node] = pn; > -- > 2.33.1
On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote: > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Roman Gushchin <guro@fb.com> Thanks!
On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote: > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Mike Rapoport <rppt@linux.ibm.com> > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 11715f7323c0..a504616f904a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > } > > lruvec_init(&pn->lruvec); > - pn->usage_in_excess = 0; > - pn->on_tree = false; > pn->memcg = memcg; > > memcg->nodeinfo[node] = pn; > -- > 2.33.1 > >
On Mon, Jan 10, 2022 at 5:03 PM Wei Yang <richard.weiyang@gmail.com> wrote: > > kzalloc_node() would set data to 0, so it's not necessary to set it > again. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Shakeel Butt <shakeelb@google.com>
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 11715f7323c0..a504616f904a 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) } lruvec_init(&pn->lruvec); - pn->usage_in_excess = 0; - pn->on_tree = false; pn->memcg = memcg; memcg->nodeinfo[node] = pn;
kzalloc_node() would set data to 0, so it's not necessary to set it again. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> --- mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-)