| Message ID | 20220111202714.1128406-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/doc: overview before functions for drm_writeback.c | expand |
Hi Dan, Thank you for the patch. On Tue, Jan 11, 2022 at 09:27:14PM +0100, Daniel Vetter wrote: > Otherwise it's really hard to link to that, which I realized when I > wanted to link to the property definitions for a question on irc. > > Fix it. > > Fixes: e2d7fc20b3e2 ("drm/writeback: wire drm_writeback.h to kernel-doc") > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Cc: Brian Starkey <brian.starkey@arm.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/gpu/drm-kms.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > index d14bf1c35d7e..6f9c064fd323 100644 > --- a/Documentation/gpu/drm-kms.rst > +++ b/Documentation/gpu/drm-kms.rst > @@ -423,12 +423,12 @@ Connector Functions Reference > Writeback Connectors > -------------------- > > -.. kernel-doc:: include/drm/drm_writeback.h > - :internal: > - > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > :doc: overview > > +.. kernel-doc:: include/drm/drm_writeback.h > + :internal: > + > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > :export: >
On Tue, Jan 11, 2022 at 10:35:22PM +0200, Laurent Pinchart wrote: > Hi Dan, > > Thank you for the patch. > > On Tue, Jan 11, 2022 at 09:27:14PM +0100, Daniel Vetter wrote: > > Otherwise it's really hard to link to that, which I realized when I > > wanted to link to the property definitions for a question on irc. > > > > Fix it. > > > > Fixes: e2d7fc20b3e2 ("drm/writeback: wire drm_writeback.h to kernel-doc") > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Cc: Brian Starkey <brian.starkey@arm.com> > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks for the quick rb, patch pushed. -Daniel > > > --- > > Documentation/gpu/drm-kms.rst | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > > index d14bf1c35d7e..6f9c064fd323 100644 > > --- a/Documentation/gpu/drm-kms.rst > > +++ b/Documentation/gpu/drm-kms.rst > > @@ -423,12 +423,12 @@ Connector Functions Reference > > Writeback Connectors > > -------------------- > > > > -.. kernel-doc:: include/drm/drm_writeback.h > > - :internal: > > - > > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > > :doc: overview > > > > +.. kernel-doc:: include/drm/drm_writeback.h > > + :internal: > > + > > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > > :export: > > > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index d14bf1c35d7e..6f9c064fd323 100644 --- a/Documentation/gpu/drm-kms.rst +++ b/Documentation/gpu/drm-kms.rst @@ -423,12 +423,12 @@ Connector Functions Reference Writeback Connectors -------------------- -.. kernel-doc:: include/drm/drm_writeback.h - :internal: - .. kernel-doc:: drivers/gpu/drm/drm_writeback.c :doc: overview +.. kernel-doc:: include/drm/drm_writeback.h + :internal: + .. kernel-doc:: drivers/gpu/drm/drm_writeback.c :export:
Otherwise it's really hard to link to that, which I realized when I wanted to link to the property definitions for a question on irc. Fix it. Fixes: e2d7fc20b3e2 ("drm/writeback: wire drm_writeback.h to kernel-doc") Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: Brian Starkey <brian.starkey@arm.com> Cc: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Documentation/gpu/drm-kms.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)