diff mbox series

[02/31] staging: wfx: fix HIF API license

Message ID 20220113085524.1110708-3-Jerome.Pouiller@silabs.com (mailing list archive)
State Not Applicable
Delegated to: Johannes Berg
Headers show
Series staging/wfx: apply suggestions from the linux-wireless review | expand

Commit Message

Jérôme Pouiller Jan. 13, 2022, 8:54 a.m. UTC
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

Apache-2.0 is not allowed in the kernel.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
 drivers/staging/wfx/hif_api_cmd.h     | 2 +-
 drivers/staging/wfx/hif_api_general.h | 2 +-
 drivers/staging/wfx/hif_api_mib.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Kalle Valo Jan. 13, 2022, 11:50 a.m. UTC | #1
Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:

> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Apache-2.0 is not allowed in the kernel.
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
>  drivers/staging/wfx/hif_api_cmd.h     | 2 +-
>  drivers/staging/wfx/hif_api_general.h | 2 +-
>  drivers/staging/wfx/hif_api_mib.h     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
> index b0aa13b23a51..b1829d01a5d9 100644
> --- a/drivers/staging/wfx/hif_api_cmd.h
> +++ b/drivers/staging/wfx/hif_api_cmd.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: Apache-2.0 */
> +/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */

Is the Apache-2.0 license really mandatory? LICENSES/dual/Apache-2.0 is
not really supportive.
Jérôme Pouiller Jan. 13, 2022, 12:16 p.m. UTC | #2
On Thursday 13 January 2022 12:50:23 CET Kalle Valo wrote:
> Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
> 
> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >
> > Apache-2.0 is not allowed in the kernel.
> >
> > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> > ---
> >  drivers/staging/wfx/hif_api_cmd.h     | 2 +-
> >  drivers/staging/wfx/hif_api_general.h | 2 +-
> >  drivers/staging/wfx/hif_api_mib.h     | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
> > index b0aa13b23a51..b1829d01a5d9 100644
> > --- a/drivers/staging/wfx/hif_api_cmd.h
> > +++ b/drivers/staging/wfx/hif_api_cmd.h
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: Apache-2.0 */
> > +/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
> 
> Is the Apache-2.0 license really mandatory? LICENSES/dual/Apache-2.0 is
> not really supportive.

[usual "I am not a lawyer" preamble]

hmm... I don't think it is really mandatory. However, I would more
confident if we could keep the original license also (I think the idea
behind is to not prevent someone to reuse this header in any other
project).
diff mbox series

Patch

diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
index b0aa13b23a51..b1829d01a5d9 100644
--- a/drivers/staging/wfx/hif_api_cmd.h
+++ b/drivers/staging/wfx/hif_api_cmd.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
 /*
  * WF200 hardware interface definitions
  *
diff --git a/drivers/staging/wfx/hif_api_general.h b/drivers/staging/wfx/hif_api_general.h
index 5f74f829b7df..3e5c92e12d35 100644
--- a/drivers/staging/wfx/hif_api_general.h
+++ b/drivers/staging/wfx/hif_api_general.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
 /*
  * WF200 hardware interface definitions
  *
diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
index da534f244757..be76e2766880 100644
--- a/drivers/staging/wfx/hif_api_mib.h
+++ b/drivers/staging/wfx/hif_api_mib.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
 /*
  * WF200 hardware interface definitions
  *