diff mbox series

kselftests/net: adapt the timeout to the largest runtime

Message ID 20220113072859.3431-1-lizhijian@fujitsu.com (mailing list archive)
State Accepted
Commit de0e444706ed98f2a13275a988d8595184be6d5c
Delegated to: Netdev Maintainers
Headers show
Series kselftests/net: adapt the timeout to the largest runtime | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 2 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Li Zhijian Jan. 13, 2022, 7:28 a.m. UTC 
timeout in settings is used by each case under the same directory, so
it should adapt to the maximum runtime.

A normally running net/fib_nexthops.sh may be killed by this unsuitable
timeout. Furthermore, since the defect[1] of kselftests framework,
net/fib_nexthops.sh which might take at least (300 * 4) seconds would
block the whole kselftests framework previously.
$ git grep -w 'sleep 300' tools/testing/selftests/net
tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
tools/testing/selftests/net/fib_nexthops.sh:    sleep 300

Enlarge the timeout by plus 300 based on the obvious largest runtime
to avoid the blocking.

[1]: https://www.spinics.net/lists/kernel/msg4185370.html

Signed-off-by: Zhou Jie <zhoujie2011@fujitsu.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
 tools/testing/selftests/net/settings | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 13, 2022, 1 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 13 Jan 2022 15:28:59 +0800 you wrote:
> timeout in settings is used by each case under the same directory, so
> it should adapt to the maximum runtime.
> 
> A normally running net/fib_nexthops.sh may be killed by this unsuitable
> timeout. Furthermore, since the defect[1] of kselftests framework,
> net/fib_nexthops.sh which might take at least (300 * 4) seconds would
> block the whole kselftests framework previously.
> $ git grep -w 'sleep 300' tools/testing/selftests/net
> tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
> tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
> tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
> tools/testing/selftests/net/fib_nexthops.sh:    sleep 300
> 
> [...]

Here is the summary with links:
  - kselftests/net: adapt the timeout to the largest runtime
    https://git.kernel.org/netdev/net/c/de0e444706ed

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
index 694d70710ff0..dfc27cdc6c05 100644
--- a/tools/testing/selftests/net/settings
+++ b/tools/testing/selftests/net/settings
@@ -1 +1 @@ 
-timeout=300
+timeout=1500