diff mbox series

[net] net/smc: Remove unused function declaration

Message ID 1642167345-77338-1-git-send-email-guwen@linux.alibaba.com (mailing list archive)
State Accepted
Commit 9404bc1e58e4bed41f629da9e3b890b2ca1f8b9c
Delegated to: Netdev Maintainers
Headers show
Series [net] net/smc: Remove unused function declaration | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: dust.li@linux.alibaba.com; 1 maintainers not CCed: dust.li@linux.alibaba.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Wen Gu Jan. 14, 2022, 1:35 p.m. UTC
The declaration of smc_wr_tx_dismiss_slots() is unused.
So remove it.

Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
---
 net/smc/smc_wr.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Dust Li Jan. 15, 2022, 10:25 a.m. UTC | #1
On Fri, Jan 14, 2022 at 09:35:45PM +0800, Wen Gu wrote:
>The declaration of smc_wr_tx_dismiss_slots() is unused.
>So remove it.

Sorry, I missed to remove this

>
>Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
>Signed-off-by: Wen Gu <guwen@linux.alibaba.com>

Reviewed-by: Dust Li <dust.li@linux.alibaba.com>

>---
> net/smc/smc_wr.h | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/net/smc/smc_wr.h b/net/smc/smc_wr.h
>index 47512cc..a54e90a 100644
>--- a/net/smc/smc_wr.h
>+++ b/net/smc/smc_wr.h
>@@ -125,10 +125,6 @@ int smc_wr_tx_v2_send(struct smc_link *link,
> int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
> 			unsigned long timeout);
> void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
>-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
>-			     smc_wr_tx_filter filter,
>-			     smc_wr_tx_dismisser dismisser,
>-			     unsigned long data);
> void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);
> 
> int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);
>-- 
>1.8.3.1
patchwork-bot+netdevbpf@kernel.org Jan. 15, 2022, 11 p.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 14 Jan 2022 21:35:45 +0800 you wrote:
> The declaration of smc_wr_tx_dismiss_slots() is unused.
> So remove it.
> 
> Fixes: 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
> ---
>  net/smc/smc_wr.h | 4 ----
>  1 file changed, 4 deletions(-)

Here is the summary with links:
  - [net] net/smc: Remove unused function declaration
    https://git.kernel.org/netdev/net/c/9404bc1e58e4

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/smc/smc_wr.h b/net/smc/smc_wr.h
index 47512cc..a54e90a 100644
--- a/net/smc/smc_wr.h
+++ b/net/smc/smc_wr.h
@@ -125,10 +125,6 @@  int smc_wr_tx_v2_send(struct smc_link *link,
 int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
 			unsigned long timeout);
 void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
-			     smc_wr_tx_filter filter,
-			     smc_wr_tx_dismisser dismisser,
-			     unsigned long data);
 void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);
 
 int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);