| Message ID | aa2344da574f58aeba869a9219b3549dbd65d8e4.1642250684.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9a9acdccdfa430457986db608ee4ae4840107057 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ethernet: sun4i-emac: Fix an error handling path in emac_probe() | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 15 Jan 2022 13:45:03 +0100 you wrote: > A dma_request_chan() call is hidden in emac_configure_dma(). > It must be released in the probe if an error occurs, as already done in > the remove function. > > Add the corresponding dma_release_channel() call. > > Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - net: ethernet: sun4i-emac: Fix an error handling path in emac_probe() https://git.kernel.org/netdev/net/c/9a9acdccdfa4 You are awesome, thank you!
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 74635a6fa8ca..621ce742ad21 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -1072,6 +1072,7 @@ static int emac_probe(struct platform_device *pdev) clk_disable_unprepare(db->clk); out_dispose_mapping: irq_dispose_mapping(ndev->irq); + dma_release_channel(db->rx_chan); out_iounmap: iounmap(db->membase); out:
A dma_request_chan() call is hidden in emac_configure_dma(). It must be released in the probe if an error occurs, as already done in the remove function. Add the corresponding dma_release_channel() call. Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/allwinner/sun4i-emac.c | 1 + 1 file changed, 1 insertion(+)