mbox series

[v4,0/2] Add SCP support for mt8186

Message ID 20220105094125.6917-1-allen-kh.cheng@mediatek.com (mailing list archive)
Headers show
Series Add SCP support for mt8186 | expand

Message

Allen-KH Cheng Jan. 5, 2022, 9:41 a.m. UTC
From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>

changes since v3:
 - use rproc-next

changes since v2:
 - remove redundant SoB

changes since v1:
 - use mt8192_power_on_sram() helper
 - add MT8186_SCP_L1_SRAM_PD_P1 in mtk_common.h
 - add MT8186_SCP_L1_SRAM_PD_P2 in mtk_common.h

Based on rproc-next

Allen-KH Cheng (2):
  dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp
  remoteproc: mediatek: Support mt8186 scp

 .../bindings/remoteproc/mtk,scp.yaml          |  1 +
 drivers/remoteproc/mtk_common.h               |  3 ++
 drivers/remoteproc/mtk_scp.c                  | 35 +++++++++++++++++++
 3 files changed, 39 insertions(+)

Comments

Mathieu Poirier Jan. 17, 2022, 5:26 p.m. UTC | #1
On Wed, Jan 05, 2022 at 05:41:23PM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
> 
> changes since v3:
>  - use rproc-next
> 
> changes since v2:
>  - remove redundant SoB
> 
> changes since v1:
>  - use mt8192_power_on_sram() helper
>  - add MT8186_SCP_L1_SRAM_PD_P1 in mtk_common.h
>  - add MT8186_SCP_L1_SRAM_PD_P2 in mtk_common.h
> 
> Based on rproc-next
> 
> Allen-KH Cheng (2):
>   dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp
>   remoteproc: mediatek: Support mt8186 scp
> 
>  .../bindings/remoteproc/mtk,scp.yaml          |  1 +
>  drivers/remoteproc/mtk_common.h               |  3 ++
>  drivers/remoteproc/mtk_scp.c                  | 35 +++++++++++++++++++
>  3 files changed, 39 insertions(+)

Both patches in this set are giving me a checkpatch warning that is impossible
to miss.  I deleting this patchset from my queue.   

> 
> -- 
> 2.18.0
>
Allen-KH Cheng Jan. 18, 2022, 1:39 a.m. UTC | #2
On Mon, 2022-01-17 at 10:26 -0700, Mathieu Poirier wrote:
> On Wed, Jan 05, 2022 at 05:41:23PM +0800, allen-kh.cheng wrote:
> > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
> > 
> > changes since v3:
> >  - use rproc-next
> > 
> > changes since v2:
> >  - remove redundant SoB
> > 
> > changes since v1:
> >  - use mt8192_power_on_sram() helper
> >  - add MT8186_SCP_L1_SRAM_PD_P1 in mtk_common.h
> >  - add MT8186_SCP_L1_SRAM_PD_P2 in mtk_common.h
> > 
> > Based on rproc-next
> > 
> > Allen-KH Cheng (2):
> >   dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp
> >   remoteproc: mediatek: Support mt8186 scp
> > 
> >  .../bindings/remoteproc/mtk,scp.yaml          |  1 +
> >  drivers/remoteproc/mtk_common.h               |  3 ++
> >  drivers/remoteproc/mtk_scp.c                  | 35
> > +++++++++++++++++++
> >  3 files changed, 39 insertions(+)
> 
> Both patches in this set are giving me a checkpatch warning that is
> impossible
> to miss.  I deleting this patchset from my queue.   

Hi Mathieu,

I find the problem is 'Reviewed-by:' is the preferred signature.

I will correct this in next version.

Thanks.

> 
> > 
> > -- 
> > 2.18.0
> >