| Message ID | 20220115012303.29651-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: sh: rz-ssi: Code cleanup and fixes | expand |
On 2022-01-15 2:22 AM, Lad Prabhakar wrote: > Hi All, > > This patch series does code cleanup and fixes to the rz-ssi driver. Hello, Suggestion for the future contributions below. My input is *not* to be treated as a blocker for the series and is not a reason for re-sending it. Cover letter should provide a high-level view of the series. That includes but is not limited to the overall layout of the series. Here, it would be good to state why the fixes are made. Also, it is preferred to have the fixes leading the series, _before_ any cleanups. This summary suggests that cleanups are leading the series instead. Think of cover-letter as of news-paper. Subsystem maintainers such as Mark and Takashi start here (read the first page first) to get the general idea of what the contributor is sending them. Being transparent only helps. Good descriptions also helps reviewers to know which patches to look at first. Fixes are obviously of more importance as they usually address issues troubling users of the release-builds. Such patches are also often backported down the stream, increasing the importance for their review. There's more to it, but for the scope of this cover letter, this should suffice. It's just a suggestion but I hope you find it useful. Regards, Czarek > Cheers, > Prabhakar > > Lad Prabhakar (5): > ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively > ASoC: sh: rz-ssi: Make the data structures available before > registering the handlers > ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() > ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to > bool > ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function > > sound/soc/sh/rz-ssi.c | 107 +++++++++++++++++++++--------------------- > 1 file changed, 54 insertions(+), 53 deletions(-) >
Hi Cezary, On Wed, Jan 19, 2022 at 2:12 PM Cezary Rojewski <cezary.rojewski@intel.com> wrote: > > On 2022-01-15 2:22 AM, Lad Prabhakar wrote: > > Hi All, > > > > This patch series does code cleanup and fixes to the rz-ssi driver. > > Hello, > > Suggestion for the future contributions below. My input is *not* to be > treated as a blocker for the series and is not a reason for re-sending it. > > > Cover letter should provide a high-level view of the series. That > includes but is not limited to the overall layout of the series. Here, > it would be good to state why the fixes are made. Also, it is preferred > to have the fixes leading the series, _before_ any cleanups. > > This summary suggests that cleanups are leading the series instead. > Think of cover-letter as of news-paper. Subsystem maintainers such as > Mark and Takashi start here (read the first page first) to get the > general idea of what the contributor is sending them. Being transparent > only helps. Good descriptions also helps reviewers to know which patches > to look at first. Fixes are obviously of more importance as they usually > address issues troubling users of the release-builds. Such patches are > also often backported down the stream, increasing the importance for > their review. > > There's more to it, but for the scope of this cover letter, this should > suffice. It's just a suggestion but I hope you find it useful. > > Thank you for the valuable input. I'll make a note of it and make sure to add more information in cover letters too. Cheers, Prabhakar
On Sat, 15 Jan 2022 01:22:58 +0000, Lad Prabhakar wrote: > This patch series does code cleanup and fixes to the rz-ssi driver. > > Cheers, > Prabhakar > > Lad Prabhakar (5): > ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively > ASoC: sh: rz-ssi: Make the data structures available before > registering the handlers > ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() > ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to > bool > ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively commit: 6570f991582e32b7992601d0497c61962a2c5dcc [2/5] ASoC: sh: rz-ssi: Make the data structures available before registering the handlers commit: 0788785c78342d422f93b1c9831c2b2b7f137937 [3/5] ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() commit: 4f78f3c970f131a179fd135806a9b693fa606beb [4/5] ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to bool (no commit info) [5/5] ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function (no commit info) All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi Mark, On Tue, Jan 25, 2022 at 10:20 AM Mark Brown <broonie@kernel.org> wrote: > > On Sat, 15 Jan 2022 01:22:58 +0000, Lad Prabhakar wrote: > > This patch series does code cleanup and fixes to the rz-ssi driver. > > > > Cheers, > > Prabhakar > > > > Lad Prabhakar (5): > > ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively > > ASoC: sh: rz-ssi: Make the data structures available before > > registering the handlers > > ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() > > ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to > > bool > > ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function > > > > [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively > commit: 6570f991582e32b7992601d0497c61962a2c5dcc > [2/5] ASoC: sh: rz-ssi: Make the data structures available before registering the handlers > commit: 0788785c78342d422f93b1c9831c2b2b7f137937 > [3/5] ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() > commit: 4f78f3c970f131a179fd135806a9b693fa606beb > [4/5] ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to bool > (no commit info) > [5/5] ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function > (no commit info) > It looks like you have applied v1 series instead of v2 to your next [0] (v2 series [1]). And your comment on your patch 1/5 of not being applying isn't true as you have already applied it ;). You haven't applied patch 5/5 (this applies cleanly to your -next) [0] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/ [1] https://patchwork.kernel.org/project/alsa-devel/list/?series=605672 Cheers, Prabhakar
On Tue, Jan 25, 2022 at 12:25:32PM +0000, Lad, Prabhakar wrote: > It looks like you have applied v1 series instead of v2 to your next > [0] (v2 series [1]). And your comment on your patch 1/5 of not being > applying isn't true as you have already applied it ;). > You haven't applied patch 5/5 (this applies cleanly to your -next) Like I said, please resend.
On Tue, Jan 25, 2022 at 12:30 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Jan 25, 2022 at 12:25:32PM +0000, Lad, Prabhakar wrote: > > > It looks like you have applied v1 series instead of v2 to your next > > [0] (v2 series [1]). And your comment on your patch 1/5 of not being > > applying isn't true as you have already applied it ;). > > You haven't applied patch 5/5 (this applies cleanly to your -next) > > Like I said, please resend. Will do. Cheers, Prabhakar
Hi All, This patch series does code cleanup and fixes to the rz-ssi driver. Cheers, Prabhakar Lad Prabhakar (5): ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively ASoC: sh: rz-ssi: Make the data structures available before registering the handlers ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to bool ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function sound/soc/sh/rz-ssi.c | 107 +++++++++++++++++++++--------------------- 1 file changed, 54 insertions(+), 53 deletions(-)